Ticket #9657 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Race condition in SNSLIveEventDataListener

Reported by: Ross Miller Owned by: Ross Miller
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The beam monitor packet parsing code in the SNS live listener has a race condition.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Ross Miller

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Ross Miller

Fix race condition parsing beam monitor packets

There was a race condition handling the beam monitor packets because we weren't locking the mutex before acquiring a pointer to the monitor workspace. Fixed by locking the mutex earlier.

Refs #9657

Changeset: 5f75f91776cbd3d2ccad63599f01760c8dd71737

comment:4 Changed 6 years ago by Ross Miller

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:6 Changed 6 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/9657_beam_monitor_race'

Full changeset: ​cfbb6e76ed0751334ba6319abb4a24fad57ddb2c

comment:7 Changed 6 years ago by Russell Taylor

Tested by code inspection as I never saw a crash before the change was applied.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10500

Note: See TracTickets for help on using tickets.