Ticket #9687 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SaveNexus no longer saves history

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Wedel

Description

In the GUI ticket for history I had to swap to filling the history object after the algorithm is executed. Adding the following line:

m_history->fillAlgorithmHistory(this, start_time, duration, Algorithm::g_execCount);

SaveNexus and SaveNexusProcessed stills relies on it being filled before being saved to file so we need to modify lines 162 and 311 in the algorithm cpp files respectively.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9687 Use fill algorithm history function in SaveNexus.

Changeset: 086d5e85bc393556d68fadca1047bd5de448a92d

comment:3 Changed 6 years ago by Samuel Jackson

Refs #9687 Fix typo.

Changeset: c8fb0ad9701ba2745fd050650fe217dc4fa9ec1c

comment:4 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

Try creating a workspace, saving it out to file, deleting it then loading it back in. If you check the history on the loaded workspace it should now show an entry for the algorithm. Check this with both SaveNexus and SavNexusProcessed.

Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:5 Changed 6 years ago by Michael Wedel

  • Status changed from verify to verifying
  • Tester set to Michael Wedel

comment:6 Changed 6 years ago by Michael Wedel

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9687_save_nexus_not_saving_history'

Full changeset: ​b2c77f971db53aca5a3d900937d6201844945c47

comment:7 Changed 6 years ago by Michael Wedel

Everything works as described in the testing information. SaveNexus and SaveNexusProcessed both appear in the history after loading the files generated by those algorithms.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10529

Note: See TracTickets for help on using tickets.