Ticket #9708 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ProcessBackground cannot be launched from Python script

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Wenduo Zhou) (diff)

This script: LoadAscii(Filename=r'/Users/wzz/Projects/Tickets/Doc/LeBailFit_Related/Test2013D_August/Data/PG3_15035-3.dat',OutputWorkspace='PG3_15035-3',Unit='TOF') ProcessBackground(InputWorkspace='PG3_15035-3',

WorkspaceIndex = 0, OutputWorkspace='PG3_15035-3_BkgdPts', Options='SelectBackgroundPoints', LowerBound='9726',UpperBound='79000', BackgroundType = 'Polynomial', SelectionMode='FitGivenDataPoints', BackgroundPoints='10082,10591,11154,12615,13690,13715,15073,16893,17764,19628,21318,24192,35350,44212,50900,60000,69900,79000', BackgroundPointSelectMode = "All Background Points", NoiseTolerance = 0.10, OutputBackgroundType = "Polynomial", OutputBackgroundOrder = 6, OutputBackgroundParameterWorkspace = "XXX")

has an error message as:

AttributeError: 'Property' object has no attribute 'isOptional'

at line 17 in '/Users/wzz/Projects/Tickets/Doc/ProcessBackgroundTest1.py' caused by line 568 in '/Applications/MantidPlot.app/Contents/MacOS/mantid/simpleapi.py' caused by line 457 in '/Applications/MantidPlot.app/Contents/MacOS/mantid/simpleapi.py'

Though the script is generated from GeneratePythonScript.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

  • Description modified (diff)

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

Is this really a critical item for this release?

It seems a bit of a rare occurrence.

comment:4 Changed 6 years ago by Wenduo Zhou

  • Priority changed from critical to major
  • Milestone changed from Release 3.2 to Release 3.3

It is moved to release 3.3 because writing the usage example of ProcessBackground is no longer required by ticket #9573.

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Checkpointing work for selecting bkgd points. Refs #9708.

Changeset: 4c12c915fdd4332051dfeafe41e46cd885e2d560

comment:6 Changed 6 years ago by Wenduo Zhou

Refs #9708. Solved the issue.

and improved documentation. Added a new test data in AutoTestData/UsageData.

Changeset: 6d436df71b1e4e7fcf3b3b3fe7e9a1cb3bc5c44c

comment:7 Changed 6 years ago by Wenduo Zhou

Tried to fix doc build. Refs #9708.

Changeset: a6a911479a53b7b8d53b109447cc719833ae44ba

comment:8 Changed 6 years ago by Wenduo Zhou

Tried to fix 2 failures. Refs #9708.

Changeset: dbecc31851ae0bb046c79b58f9c9b2bd05981ec0

comment:9 Changed 6 years ago by Wenduo Zhou

Tried to fix the last failure. Refs #9708.

Changeset: 8b21e3073eeedba17e2c54fd8f8b597e6195db37

comment:10 Changed 6 years ago by Wenduo Zhou

Hopefully fixed the error. Refs #9708.

Changeset: e7494deeb9d469375deb4a64c26569e8fc76d021

comment:11 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester

The goal of this ticket is to solve the problem when running this algorithm in python. The sphinx documentation is finished under this ticket as well.

You could check the unit tests and the examples from its doc page.

comment:12 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:13 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9708_processbkgd_python'

Full changeset: ​29fdeeb42cc0a5187b232eb0539d2952385dbfc6

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10550

Note: See TracTickets for help on using tickets.