Ticket #9710 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix Unit Label for ISIS SANS Reduction

Reported by: Peter Parker Owned by: Peter Parker
Priority: critical Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

The ISIS SANS 1D reduction does not produce workspaces with the required Y Axis units. Plotting the workspaces should show a YAxis with label I(q) (cm-1).

Also, given a non-empty YUnitLabel string, a PlotAxis should then display that string instead of any other unit settings. This is currently not the case, so this should be fixed.

Change History

comment:1 Changed 6 years ago by Peter Parker

Refs #9710. Fix unit label.

Manually overwrite our own label at the end of the reduction.

Fix PolotAxis so that if the YUnitLabel of an axis has been set, then that should be displayed in plots instead of any other unit settings.

Changeset: 884eef8d41d0fd9e21c3b63643c3e8d667c28335

comment:2 Changed 6 years ago by Peter Parker

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Peter Parker

  • Status changed from assigned to verify
  • Resolution set to fixed

Test Y-Unit labels:

  • Create your own workspace with units of, for example, wavelength. Do a "Plot Spectrum..." and make sure the label is as you would expect.
  • In the Python scripting window, change the Y Axis label using setYLabel. Replot the graph and make sure the label has now been changed.

Test unit label of ISIS SANS reduction:

  • Add the LOQ data directory of the system tests repo to your managed directories, and run the following script:
from ISISCommandInterface import *

LOQ()
Detector("main-detector-bank")
MaskFile('MASK.094AA')
# apply some small artificial shift
SetDetectorOffsets('REAR', -1.0, 1.0, 0.0, 0.0, 0.0, 0.0)    
Gravity(True)

AssignSample('99630.RAW')
AssignCan('99631.RAW')

result = WavRangeReduction(None, None, False)
plotSpectrum(result, 0)
  • Make sure the Y-Axis label of the resulting plot is "I(q) (cm-1)".

comment:4 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9710_fix_unit_label_for_isis_sans_reduction'

Full changeset: d91d0c9c0d15d4e42de850f03156a4c40890a798

comment:6 Changed 6 years ago by Anders Markvardsen

label show up correctly

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10552

Note: See TracTickets for help on using tickets.