Ticket #9713 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Clean up commented out code in LoadILL & LoadILLReflectometry

Reported by: Samuel Jackson Owned by: Ricardo Leal
Priority: trivial Milestone: Release 3.3
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

I spotted this in a couple of places:

  • 391 - LoadILL
  • 321 - LoadILL
  • 291 - LoadILLReflectometry

Although there might be more...

Change History

comment:1 Changed 6 years ago by Ricardo Leal

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from assigned to inprogress

Re #9713 Clean up comments

Changeset: a4a1ed553673978c3c587232affd423d84188210

comment:3 Changed 6 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:5 Changed 6 years ago by Harry Jeffery

Changes reviewed with git diff -w to identify non-whitespace changes.

Behavioural changes found:

  • A std::ostream << NXClassInfo definition was removed from NXClassInfo
  • m_wavelength and m_channelWidth are now initialised to 0 in the LoadILLReflectometry constructor.

Since the build and tests pass, the << definition was fine to go as it was not used, and initialising variables is always a good thing.

All other changes are documentation or comments.

Passing.

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9713_9919_clean_up_and_usage_examples'

Full changeset: ​b0a29188b2a4815bf128fdc83568a274ed83e8d9

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10555

Note: See TracTickets for help on using tickets.