Context Navigation

← Previous Ticket
Next Ticket →

Ticket #9720 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Apply Corrections fails with old OSIRIS files

Reported by:	Samuel Jackson	Owned by:	Samuel Jackson
Priority:	critical	Milestone:	Release 3.2
Component:	Indirect Inelastic	Keywords:
Cc:		Blocked By:
Blocking:		Tester:	Peter Parker

Description

Reported by Sanghamitra:

Today morning I tried to use ‘Use Can’ option available in IDA Apply Correction on Run 110041 (sample) and 103358 (can) (OSIRIS, Analyser: graphite, 002, mapping:All), but receive the following error:

Error in execution of algorithm Minus:

X arrays must match when performing this operation on a 2D workspaces.
ValueError: X arrays must match when performing this operation on a 2D workspaces.
at line 16 in '<Interface>'
caused by line 1302 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py'
caused by line 567 in 'C:/MantidInstall/bin\mantid\simpleapi.py'

This is because 103358 is an old run with a shorter range. Her suggestion is to rebin the can to the sample if the bins don't match and spit out a warning that it is doing so.

Change History

comment:1 Changed 6 years ago by Samuel Jackson

Summary changed from Apply Corrections fails with old versions OSIRIS files to Apply Corrections fails with old OSIRIS files

comment:2 Changed 6 years ago by Samuel Jackson

Priority changed from major to critical
Milestone changed from Backlog to Release 3.2

Modifying status on Nick's advice.

comment:3 Changed 6 years ago by Nick Draper

Status changed from new to assigned

comment:4 Changed 6 years ago by Samuel Jackson

Status changed from assigned to inprogress

Refs #9720 Check if the binning is the same.

If not run RebinToWorkspace and output a warning.

Changeset: 74b5ff449674289fbb9f46cf86d2801a47e0facf

comment:5 Changed 6 years ago by Samuel Jackson

Refs #9720 Add option to rebin can to match sample.

Changeset: 9f0e804c18c5c94b0ab05cd8dd4cd1aeff7f5cec

comment:6 Changed 6 years ago by Samuel Jackson

Refs #9720 Modify interface to ask user to confirm operation.

Changeset: 4ac912e79d9ac8a4488d8957b73330c7cddc698b

comment:7 Changed 6 years ago by Samuel Jackson

Merge branch 'bugfix/9720_apply_corrections_fails_with_older_files' into develop

Refs #9720

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Changeset: d124bb6a982b7787ba0df562e07beb5829529504

comment:8 Changed 6 years ago by Samuel Jackson

Refs #9720 Include option in complex corrections.

Changeset: b0c34d12efa1ae3c3a8a91f37743b7d24b5d4521

comment:9 Changed 6 years ago by Samuel Jackson

Merge branch 'bugfix/9720_apply_corrections_fails_with_older_files' into develop

Refs #9720

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Changeset: 44024bd59739813fedc7b0c2ed8ca58c12305127

comment:10 Changed 6 years ago by Samuel Jackson

Refs #9720 Better error message.

Changeset: a9e53966121169d65bb927f39bea88d075795654

comment:11 Changed 6 years ago by Samuel Jackson

To Test

Open the manage directories window and check search instrument archive.
Open Convert to energy and select OSIRIS as the instrument.
Type the run numbers 110041, 103358 and click run.
Open apply corrections and use 110041 as the sample and 103358 as the can.
Running should ask you if you wish to rebin one to the other.
Clicking yes should allow the routine to succeed.
Clicking no should stop the program.
Code review.

comment:12 Changed 6 years ago by Samuel Jackson

Status changed from inprogress to verify
Resolution set to fixed

comment:13 Changed 6 years ago by Peter Parker

Status changed from verify to verifying
Tester set to Peter Parker

comment:14 Changed 6 years ago by Peter Parker

Status changed from verifying to reopened
Resolution fixed deleted

Could I pass this one back to you so that you can remerge master into it, please? There was a conflict in IndirectDataAnalysis.py at around lines 967 and 989.

comment:15 Changed 6 years ago by Samuel Jackson

Status changed from reopened to inprogress

Merge remote-tracking branch 'origin/master' into bugfix/9720_apply_corrections_fails_with_older_files

Refs #9720

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Changeset: 3d7f6697947863040bfea7204c570c11aec44a24

comment:16 Changed 6 years ago by Samuel Jackson

Merge branch 'bugfix/9720_apply_corrections_fails_with_older_files' into develop

Refs #9720

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Changeset: 454a87399f9335cbfe6f5ed552b308438ab35b9c

comment:17 Changed 6 years ago by Samuel Jackson

Status changed from inprogress to verify
Resolution set to fixed

comment:18 Changed 6 years ago by Peter Parker

Status changed from verify to verifying

comment:19 Changed 6 years ago by Peter Parker

Status changed from verifying to reopened
Resolution fixed deleted

As discussed, a slight improvement could be made to the message, making it clear that nothing at all will happen if the user clicks "no" (should this be "cancel"?), and that clicking "yes" (should this be "ok"?) will do the rebinning, though it is not recommended a user does this.

Apart from that, the rest is great.