Ticket #9729 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LARMOR tube calibration fails

Reported by: Karl Palmen Owned by: Peter Parker
Priority: blocker Milestone: Release 3.2
Component: Framework Keywords:
Cc: robert.dalgliesh@… Blocked By: #9632
Blocking: Tester: Roman Tolchenov

Description

The attached script that calibrates LARMOR tubes worked one release 3.1.0 but now fails to calibrate.

The error message "Tube specification not valid" is given and no tube calibration takes place.

I bug fixed by #9632 prevented the script from getting far enough to show this, so blocks this ticket.

Attachments

Rebert_Dalgleish01.py​ (685 bytes) - added by Karl Palmen 6 years ago.
A LARMOR tube calibration script that works for release 3.1.0

Change History

Changed 6 years ago by Karl Palmen

A LARMOR tube calibration script that works for release 3.1.0

comment:1 Changed 6 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Karl Palmen

The IDF for LARMOR was changed by Peter Parker on 18 June.

I tried the script with the old IDF got from the MantidInstall of release 3.1.0 and it works.

This shows the change of 18 June has broken the tube calibration.

comment:3 Changed 6 years ago by Karl Palmen

The problem appears to be caused by spaces after the tube names in the modified IDF file.

comment:4 Changed 6 years ago by Karl Palmen

  • Owner changed from Karl Palmen to Peter Parker

comment:5 Changed 6 years ago by Peter Parker

  • Cc robert.dalgliesh@… added

comment:6 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9729 - Remove spaces from tube names.

Changeset: 119a130e3788de31175790e4e99ec8f2a07b11b1

comment:7 Changed 6 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Peter Parker

  • Status changed from verify to reopened
  • Resolution fixed deleted

Reopened. I've just been given a new version from Rob.

Last edited 6 years ago by Peter Parker (previous) (diff)

comment:9 Changed 6 years ago by Peter Parker

  • Status changed from reopened to inprogress

Refs #9729 - Updated IDF from Rob.

Changeset: 4f5261f6a0986ca9382c5772f543685ada238ab7

comment:10 Changed 6 years ago by Peter Parker

Refs #9729 - Remove commented-out line.

Changeset: 82abe6ec0100648ec03996306b2e26186d838be6

comment:11 Changed 6 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

Rob's script (attached) should now work. You will need to add the latest LARMOR data folder from the archive to your managed directories.

comment:12 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:13 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9729_remove_spaces_from_larmor_idf'

Full changeset: ​1b6c8939c74ce5ce55f84c106b646da88fe3396d

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10571

Note: See TracTickets for help on using tickets.