Ticket #9736 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Calibration file creation includes averaging of zero spectra

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: critical Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Karl Palmen

Description

We're using SumSpectra in the NormaliseToUnity step, which appends the log value NumZeroSpectra. Subtract this from the total number of histograms when normalising.

Attachments

osiris00108380.raw​ (2.0 MB) - added by Samuel Jackson 6 years ago.
The file which had zero spectra.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9736 Remove zeroed spectra from average.

Changeset: 23aa88504e2d18019afac1191f8d70a46faad564

Changed 6 years ago by Samuel Jackson

The file which had zero spectra.

comment:3 Changed 6 years ago by Samuel Jackson

To Test

  • Grab the file on the ticket and open Indirect > C2E > Energy transfer
  • Set the Spectra Max to be 1010 and choose OSIRIS.
  • Swap to the Calibration tab and used the file to create a calibration workspace. The file has some zero spectra near the bottom, so averaging the workspace will be biased.
  • Run it again as above with the changes applied and note the difference.
  • Run it again with and without the changes applied, but this time don't change the Spectra Max option. The results should be identical.
  • Code Review
Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:4 Changed 6 years ago by Samuel Jackson

Refs #9736 Use FindDetectorsOutsideLimits instead.

Also do a little light refactoring while we're here.

Changeset: 38e6e15d6c3f70bb6690b2b8fa0227e3d1f5bd68

comment:5 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:7 Changed 6 years ago by Karl Palmen

I saved thre four calibration workspaces to nexus so I could compare them together and got only the old 1010 workspace differing from the others (new 1010, old 1004 & new 1004), which is the requirement.

comment:8 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9736_calib_sum_zero_spec'

Full changeset: ​a897b6fb6a51e1a73354cd5b303a18cc562ab431

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10578

Note: See TracTickets for help on using tickets.