Ticket #9743 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix "events.binning" crash

Reported by: Peter Parker Owned by: Peter Parker
Priority: blocker Milestone: Release 3.2
Component: SANS Keywords:
Cc: robert.dalgliesh@…, richard.heenan@…, stephen.king@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The beam centre finder (probably amongst other things) is not working since the changes in #8931. The interface is looking for a non-existant property inside the reducer's PropertyManager and throwing when it doesn't find it.

Hopefully a simple fix.

Change History

comment:1 Changed 6 years ago by Peter Parker

Refs #9743 - Fix crash.

No longer trying to set the proeprty when it does not exist.

Changeset: f81d5ec3404bddc0d3e7d1834b06573c0c755e89

comment:2 Changed 6 years ago by Peter Parker

Tester:

  • Add System Tests/Data/LOQ to your managed directories.
  • Open the ISIS SANS interface, and select the LOQ instrument.
  • Load the "MaskLOQData.txt" User File.
  • Type "74044" into the Scattering/Sample field and click "Load Data".
  • Go to the Geometry tab and set the "Max. iterations" field 1.
  • Click "Run" in the bottom right hand corner of the same tab.

Effectively, if Mantid doesn't crash, then this fix has worked.

If you really want to you can carry out the testing procedure for #8931 again, but that might take a while and I think it's overkill in this case.

comment:3 Changed 6 years ago by Peter Parker

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Peter Parker

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:6 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9743_fix_events_binning_crash'

Full changeset: ​556d1114df4728451fa291ab55ea0a3d7c269e8b

comment:7 Changed 6 years ago by Anders Markvardsen

mantid did not crash

comment:8 Changed 6 years ago by Peter Parker

  • Component changed from Framework to SANS

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10585

Note: See TracTickets for help on using tickets.