Ticket #9764 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix binary operations in SNSPowderReduction

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: blocker Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Binary divide and minus are no longer done in place. This breaks the reduction. Fix the reduction and then create a ticket for adding a system test that would have pointed this out.

This was introduced in ​da13fea922.

Change History

comment:1 Changed 6 years ago by Pete Peterson

Re #9764. Changing binary operations to be in-place again.

Changeset: 78bdc903cbd61952ecf5e47d63a08e9235f848c6

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

Pete,

Martyn and I are not sure what difference this change will make. If you know better could you educate us

comment:4 Changed 6 years ago by Peter Peterson

  • Status changed from assigned to verify
  • Resolution set to fixed

The fix is to make things back in-place.

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:6 Changed 6 years ago by Wenduo Zhou

The bug is fixed. Ticket is thus closed.

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9764_snspowder_binary_ops'

Full changeset: ​8893dfa3b1c15e1a49fb990c4face656f57d042d

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10606

Note: See TracTickets for help on using tickets.