Ticket #9769 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Implement Normalize to monitor 2

Reported by: Alex Buts Owned by: Alex Buts
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: devashibhai.adroja@… Blocked By:
Blocking: #9581 Tester: Nick Draper

Description

In cases when chopper changes (and user does not need absolute normalization?), this is the way to work with two runs having different choppers.

Change History

comment:1 Changed 6 years ago by Alex Buts

refs #9769 Spelling errors in NormaliseToMonitor

Changeset: 7e821c09106d9109309018873276f62598bcdfea

comment:2 Changed 6 years ago by Alex Buts

refs #9769 draft normaliseToMonitor2 implementation

Changeset: 9fc2429d65adc0562f459d258b45009e8504a8d6

comment:3 Changed 6 years ago by Alex Buts

refs #9769 All works but question if correctly remains

Changeset: 1fe80a7719d6655c4f1f5a115b9f37167a512dbe

comment:4 Changed 6 years ago by Alex Buts

refs #9769 Helper method to get normalization workspace from the alg:

NormaliseToMonitor

Changeset: fa9857a9d77b2c2e91283418821de455ecf843e0

comment:5 Changed 6 years ago by Alex Buts

refs #9769 Allow WB workspace to be normalized by current if no mon

found in the workspace or near

Changeset: e73edfb502c691e00c81ce6a0751e3bead97e5b1

comment:6 Changed 6 years ago by Alex Buts

refs #9769 Test for normalize to monitor-2

Changeset: 4669cf76ff1d03aaa70129e2dfb0aacea9216d3e

comment:7 Changed 6 years ago by Alex Buts

refs #9769 unit tests for the changes

Changeset: 379214880de1f9d4518a2901eed2d870a3e7a46d

comment:8 Changed 6 years ago by Alex Buts

refs #9769 Trying to fix Unix compilation error

Changeset: bcf678434fa8a3e28d4543ad3bf775a0179a9a49

comment:9 Changed 6 years ago by Alex Buts

refs #9769 fighting with Unix compilation error

Changeset: 4303c524f775675c76fb7c8319005ab58dadeb3c

comment:10 Changed 6 years ago by Alex Buts

  • Priority changed from major to critical
  • Milestone changed from Backlog to Release 3.2

comment:11 Changed 6 years ago by Alex Buts

refs #9769 unit tests for the changes

Changeset: 599c6f764def5da5f595db1be4674bbbaf006569

comment:12 Changed 6 years ago by Alex Buts

refs #9769 Reverting the changes to C++ code

related to debugging the python algorithm

Changeset: cb24e7e2884f6cf262c46c9e873c3ecc8accfb20

comment:13 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned

The branch should be merged both from Mantid and the system tests as new system test to check new option is added there.

To make this ticket safe, I've removed all C++ code changes used for debugging.

New Normalize to Monitor 2 option has been added to the ISIS python code. It formally works but it correctness will be verified by an instrument scientist.

Test by code review and verifying if all system tests run correctly.

The ticket should be merged to master before #9581, as the changes to ISIS instrument parameters break LoadInstrument python test in the documentation.

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:14 Changed 6 years ago by Alex Buts

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:15 Changed 6 years ago by Alex Buts

  • Blocking 9581 added

comment:16 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:17 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9769_NormalizeToMonitor2'

Full changeset: ​8228dce9053cd0c435cc2b60c2d939c97ecc84a8

comment:18 Changed 6 years ago by Nick Draper

Merge remote-tracking branch 'origin/feature/9769_NormalizeToMonitor2'

Full changeset: ​c5ecf0f5b2256e04c4722a0a070da033ea4d42b7

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10611

Note: See TracTickets for help on using tickets.