Ticket #9771 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Wrong initial fitting range in MuonAnalysis

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: blocker Milestone: Release 3.2
Component: Muon Keywords:
Cc: stephen.cottrell@… Blocked By:
Blocking: #9557 Tester: Nick Draper

Description

Steve writes:

I’ve noticed the following bug in the muon analysis interface that can be reproduced with the following sequence of actions:

  1. Start Mantid and the muon analysis interface
  1. Load EMU run 50272
  1. Select the ‘Data Analysis’ tab … ‘start’ and ‘end’ are not set correctly as defined in ‘settings’ tab. Note that when generating this example settings were selected to start at ‘first good data’ (0.2us) and finish at 12us, yet the data analysis parameters fixed ‘start’ at 0.6us and ‘end’ at 11.4us.
  1. Add a function – ‘expdecaymuon’ and fit. Fit takes place between incorrect limits.
  1. Select ‘settings’ tab and then immediately select ‘data analysis’ tab. Limits are now set correctly and fit occurs over the correct range.

In this ticket, make the initial fitting range equal to the data range in the settings tab.

As a bonus, only auto-update the fitting range when a new workspace is created for fitting

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress
  • Blocking 9557 added

Note reading #9557 the reason for this bug may not be related to changes in muonanalysis...

comment:3 Changed 6 years ago by Anders Markvardsen

make default in data analysis tab those setting. re #9771

Changeset: 311fb65d3a45daeaec4d25133ace2dc60baa762d

comment:4 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

Note the bonus part of this ticket has not been covered.

To test:

  1. Open MuonAnalysis in MantidPlot
  1. Click on setting tab and select some time axis interval. For example, 'Start at First Good Data and for Finish time value select 6
  1. selection to plot e.g. argus0026287.nxs from AutoTestdata
  1. click on 'Data Analysis' tab and the Start and End value should match those selected in the Settings tab

comment:5 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:6 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9771_muon_fit_range'

Full changeset: 09c31bbc914a8a46eae3f08f644310a680f41edb

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10613

Note: See TracTickets for help on using tickets.