Ticket #9784 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

EnginXCalibrateFull and EnginXCalibrate parameter names

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: critical Milestone: Release 3.2
Component: Diffraction Keywords:
Cc: saurabh.kabra@…, joe.kelleher@… Blocked By:
Blocking: #8368 Tester: Anders Markvardsen

Description (last modified by Karl Palmen) (diff)

In these two algorithms change the name of the input parameter CalibrationRun to InputWorkspace

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

I assume these are new algorithms for this release

comment:2 Changed 6 years ago by Anders Markvardsen

Yes new algorithms for this release. Hence it is therefore safe to make the name change of paramters, but important to do this before they are used in anger

comment:3 Changed 6 years ago by Karl Palmen

  • Description modified (diff)
  • Summary changed from EnginXCalibrateFull and EnginXCalibrate to EnginXCalibrateFull and EnginXCalibrate parameter names

comment:4 Changed 6 years ago by Anders Markvardsen

  • Blocking 8368 added

comment:5 Changed 6 years ago by Karl Palmen

  • Status changed from assigned to inprogress

comment:6 Changed 6 years ago by Karl Palmen

Neither of these two algorithms yet have usage example or unit test.

comment:7 Changed 6 years ago by Karl Palmen

Change the parameter/properties re #9784

Also correct the algorithm name functions, so they return the actual name of the algorithm.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d5f5e074d92e79b00c35b9de3a152ee178fdc145

comment:8 Changed 6 years ago by Karl Palmen

  • Description modified (diff)

comment:9 Changed 6 years ago by Karl Palmen

To test execute both algorithms in Mantidplot to see that the property names are as expected in the dialog box and madatory properties come first.

You may also check the documentation and the code review.

FOLLOW TEST INSTRUCTIONS STATED LATER ON.

Last edited 6 years ago by Karl Palmen (previous) (diff)

comment:10 Changed 6 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:12 Changed 6 years ago by Martyn Gigg

The systemtests have broken, ​http://builds.mantidproject.org/job/develop_systemtests_rhel6/, so this should NOT be merged yet.

Also I'm not sure I understand why the names are being changed. The property refers to a FileProperty and not a Workspace so the new name is not actually that accurate...

comment:13 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:14 Changed 6 years ago by Karl Palmen

  • Status changed from reopened to inprogress

New system test EnginXCalibrationTest needs modifying.

comment:15 Changed 6 years ago by Karl Palmen

The input property needs to be InputFile whenever it is a file specification rather than a workspace.

comment:16 Changed 6 years ago by Karl Palmen

Use 'Filename' for input file property re #9784

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6d38d3efed63d8e089162f095ff9b3e85751491c

comment:17 Changed 6 years ago by Karl Palmen

Change input property to Filename re #9784

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 2d7475e74a64d9004731e9d6820d60e68338b5f5

comment:18 Changed 6 years ago by Karl Palmen

To test:

To test execute algorithms EnginXFocus, EnginXCalibrate and EnginXCalibrateFull in Mantidplot to see that the property names are as expected in the dialog box and madatory properties come first.

You may also check the documentation and the code review.

Also test in systemtests and check SystemTests\AnalysisTests\EnginXCalibrationTest.py and verify that it works either by running it or seeing that the previous system tests have run OK.

Last edited 6 years ago by Karl Palmen (previous) (diff)

comment:19 Changed 6 years ago by Karl Palmen

correction of system test re #9784

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 084ad70f967ccd867d89c991426dc6fb04e87428

comment:20 Changed 6 years ago by Karl Palmen

Corrrection of property reference in EnginXCalibrateFull.py re #9784

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: c3383fe3e4901626dad8bfaf94d49ff3eebccd02

comment:21 Changed 6 years ago by Karl Palmen

Correct EnginXCalibrate.py re #9784

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d565436dc9f16a1da14b5b2c48c0778a90b2baf9

comment:22 Changed 6 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:23 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying

comment:24 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9784_engine_x_alg_properties'

Full changeset: ​d01b3a2a60a1f5b1212d91afafcd94902a74f855

comment:25 Changed 6 years ago by Anders Markvardsen

tested algs. ran enginxfocus usage example and systemtest has passed on build server

comment:26 Changed 6 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/9784_engine_x_calibrate_test'

Full changeset: ​48d3322db568f6b3ff50136d0eb50bc0e275e1fd

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10625

Note: See TracTickets for help on using tickets.