Ticket #9786 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Better Error Message When Using ISIS SANS Add Runs Without Default Save Directory Set

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: robert.dalgliesh@… Blocked By:
Blocking: Tester: Nick Draper

Description

Currently, when using the Add Runs tab of the ISIS SANS interface without a Default Save Directory set, the user is presented with: 

WindowsError: [Error 3] The system cannot find the path specified: ''
  at line 3 in '<Interface>'
  caused by line 156 in 'C:/Users/stv04463/Development/Mantid/Installs/20140626/scripts/SANS\SANSadd2.py'

which is not helpful. Really, we should not allow users to even click run unless they've specified an output directory.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9786 - Get rid of deprecated code while we're here.

Changeset: e1e278d333a510b0865621099b467d39f0b8a0fe

comment:3 Changed 6 years ago by Peter Parker

Refs #9786 - Also, disable summing without enough non-empty items.

Changeset: 58d7a6de45b25906e1116220166dbd770f17ebcd

comment:4 Changed 6 years ago by Peter Parker

Refs #9786 - Fix actual issue.

Changeset: 6313a9dc89b24b6d0abe071cc9f16d10b30d52fe

comment:5 Changed 6 years ago by Peter Parker

Refs #9786 - Changing my mind about where the function should go.

Changeset: 7fc946b6dfa885bd66c1a96558d98351742dd96e

comment:6 Changed 6 years ago by Peter Parker

Refs #9786 - Fix compiler warning.

Changeset: dfca5e48cbdd1e26bfbf4afccec6be2b62d7de26

comment:7 Changed 6 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Add the systemtests/Data/SANS2D folder to your managed directories.
  • Open up the ISIS SANS interface and select "SANS2D" from the instrument drop-down box.
  • Go to the "Add Runs" tab and type in the run numbers of two or more files in the folder you added previously.
  • Make sure your default save directory is not set, and click "Sum". You should get a popup saying what went wrong.
  • Set the default save directory and make sure summing still works.
  • Play around with adding / removing editing run numbers to make sure the "Sum" button is enabled/disabled as you would expect.

comment:8 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:9 Changed 6 years ago by Nick Draper

Works fine, although validation of file paths could be better, and \ are ignored if not doubled. Widgetisation of this with a more capable file list widget tied into filefinder would make better long term sense here.

comment:10 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9786_save_directory_validation_in_isis_sans_add_runs_tab'

Full changeset: ​974e15634571d94460bcae44bd70e4dacf2c26f9

comment:11 Changed 6 years ago by Peter Parker

I agree.

There are other usability issues I would also like to address, and the underlying "Add Runs" routine could also do with some work. My preference would be to start again from scratch with this tab, but time is short at the moment.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10628

Note: See TracTickets for help on using tickets.