Ticket #9789 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Update doc for EnginXCalibrateFull

Reported by: Anders Markvardsen Owned by: Lottie Greenwood
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: saurabh.kabra@… Blocked By:
Blocking: #8368 Tester: Harry Jeffery

Description

As agreed with Saurabh Kabra update doc for this algorithm.

Explaining the black-box magic better of creating the output DetectorPositions, i.e. adjusted detector pixel positions

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Lottie Greenwood

comment:3 Changed 6 years ago by Lottie Greenwood

  • Status changed from assigned to inprogress

Refs #9789 EnginXCalibrateFull RST updated

Changeset: e07a2821f00a0f081565b4024b5863027e2ef4d0

comment:4 Changed 6 years ago by Lottie Greenwood

Refs #9789 wrote equation for doc

Changeset: 6f78216cd9dc4bf3cda4a34b4090aa1017d6220d

comment:5 Changed 6 years ago by Lottie Greenwood

Refs #9789 update doc

Changeset: b33ac9ec4cfd46b9f25661f7cf48cf13b13de697

comment:6 Changed 6 years ago by Lottie Greenwood

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The Filename property for EnginXCalibrateFull should probably not be renamed. If any users have scripts that run this algorithm, they will break. The doctest for EnginXCalibrateFull is failing for this reason.

comment:9 Changed 6 years ago by Lottie Greenwood

  • Status changed from reopened to inprogress

Refs #9789 Fixed for doctests

Changeset: 5d789d6fb51daaeb5f5bf100d6e1e120eb7d4d24

comment:10 Changed 6 years ago by Lottie Greenwood

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9789_Update_doc_EnginXCalibrateFull'

Full changeset: ​4688d7d9f78defd6319604ec572fa6c8854839d0

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10631

Note: See TracTickets for help on using tickets.