Ticket #9808 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

GetDetOffsetsMultiPeaks failing on Fedora 20 & Ubuntu 14.04

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

If we want to be able to release 3.2 for these platforms, we need to fix these errors.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Initialize all member variables in FindPeaks constructor.

Eliminates a coverity warning and fixes the GetDetOffsetsMulti test. Refs #9808

Changeset: 88c9000600b3bcfbb76b35559841ad7c57b1653c

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: ​bugfix/9808_failing_unittests_gcc48

Tester: This should be tested on either Fedora 20 or Ubuntu 14.04. Before the merge the GetDetOffsetsMulti unit test should be failing. After the merge it should be passing. The fix was actually in FindPeaks, which GetDetOffsetsMulti uses.

comment:4 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Test is still failing on Fedora 20.

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

Initialize variables in FindPeaks before passing by reference.

Fixes the GetDetOffsetsMultiPeaks unit test on Fedora 20, which was discovered using valgrind and the --undef-value-errors=yes option. Refs #9808

Changeset: 5660b87397390d313bf47c55e15dd6c0ac7192d9

comment:7 Changed 6 years ago by Martyn Gigg

Retrieve result before deleting gsl structure.

Fixes an error found by valgrind. Refs #9808

Changeset: e287a34f878e8971c623ea0812c3d897fce1c26d

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

That should have fixed it. The build servers seem happy at least...

comment:9 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:10 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9808_failing_unittests_gcc48'

Full changeset: ​a9a1a8b84830129e9bb88c3f7ff7eddbbd0a872f

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10650

Note: See TracTickets for help on using tickets.