Ticket #9822 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IDA build warning for duplicate layout name.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: trivial Milestone: Release 3.3
Component: Indirect Inelastic Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

I get the following warning when building from scratch: 

/home/chs18285/git/mantid/Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui: Warning: The name 'verticalLayout_5' (QVBoxLayout) is already in use, defaulting to 'verticalLayout_51'.

Which has probably snuck in from a merge of the GUI files. Should be trivial to rename it so it no longer clashes.

Change History

comment:1 Changed 6 years ago by Samuel Jackson

Refs #9822 Remove duplicate layout name.

Changeset: 3233fda4d860a6bc78c7fe7df76b954dc09c2079

comment:2 Changed 6 years ago by Samuel Jackson

To Test

Changes are trivial. Test by code inspection. If you're really paranoid, do a fresh compile and check the warning is gone.

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Changes appear to be fine, but I cannot run git test pass because checkbuild hasn't been run yet. Please checkbuild your branch.

comment:7 Changed 6 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

Somebody probably did a develop reset. Should be in there now.

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Harry Jeffery to Martyn Gigg

comment:9 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9822_duplicate_layout_name'

Full changeset: ​95620031352cea7edff08724c5243560e4b918a7

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10664

Note: See TracTickets for help on using tickets.