Ticket #9846 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Re-insert CalMuonDeadTimeTest

Reported by: Anders Markvardsen Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.4
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

At some point CalMuonDeadTimeTest has been disabled in cmake for some reason.

Reinsert this test

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

  • Milestone changed from Release 3.3 to Backlog

comment:3 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Raquel Alvarez Banos

comment:4 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #9846 Reinserting CalMuonDeadTimeTest

Changeset: bcb081167671157bc5037d08a8d0274d17f910e1

comment:5 Changed 6 years ago by Raquel Alvarez Banos

Re #9846 Updating LoadMuonNexus in CalMuonDeadTimeTest

Changeset: 0e146929672dbb161afe7be414028b86424ff5b4

comment:6 Changed 6 years ago by Raquel Alvarez Banos

For tester: check that CalMuonDeadTimeTest has been reinserted and that all tests pass

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.4

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Could you checkbuild the branch please?

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Sure, I'll let you know when it's ready to test again. Thanks

comment:11 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from reopened to verify
  • Resolution set to fixed

Should be ready to test now.

comment:12 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Karl Palmen

comment:13 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

CalMuonDeadTimeTest has a test that has been disabled. This test is xtestCalDeadTime(). To enable it, remove the 'x' from the beginning of the test name, so it is called testCalDeadTime().

comment:14 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from reopened to inprogress

Re #9846 enabling testCalDeadTime

Changeset: 25ed27f7a1036dea06fe6d073eef71356a9b5743

comment:15 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Thanks Karl, I didn't notice that. It should be enabled now.

comment:16 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester changed from Karl Palmen to Harry Jeffery

comment:17 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9846_reinsert_CalMuonDeadTimeTest'

Full changeset: ​b483142ae02dfc3afb3fd4be3fef26aa2d912a5e

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10688

Note: See TracTickets for help on using tickets.