Slow Unit Tests for Vickie Lynch

[Owen Arnold]

Cloned from #9893:

---

We have a number of slow running unit tests which we need to fix as part of the 3.3 maintenance window. We are targeting test suits than execute in > 2 seconds on our clean rhel6 build servers. For IO tests (Loading & Saving) we have applied a more generous threshold of > 5 seconds.

See the full list to see which tests have been assigned to you: http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf

Criteria

1. Test suits (each test class instance) should execute in < 1 second as a rough target
2. As a corollary to the above, If the test suite contains lots of test methods aim for < 0.1 second per test method
3. If for some reason you get the speed up the test below the target using the strategies listed below, you need to justify why when you close the ticket.

Guidelines/instructions to help

1. Keep tests readable and improve code readability where possible. Unit tests are documentation.
2. Do not delete test methods without good reason. We do not want to reduce test coverage
3. Changing the algorithm code to improve speed is OK, but exercise caution. Add additional test coverage if it's not already good enough.
4. Take test methods that are slow and involve IO, or are processor intensive and make them into system tests. Integration tests are not Unit tests.
5. Most of the speed improvements will probably come from better selection of input data. Caching input data is also a good option.
6. Create sub tickets for algorithms or groups of algorithms to help testability if you wish, but mark this ticket as the 'blocked' by each one.

[Vickie Lynch]

Refs #9894 remove FrameworkManager::Instance() from tests

Changeset: bcb12cfce4ad2edcacadcece3bfe72d655b46f54

[Vickie Lynch]

Refs #9894 use helper for event workspace

Changeset: 5caebaab135bfea56dcfa60aa78db965889e7caf

[Vickie Lynch]

Refs #9894 fix warning

Changeset: c7309614d5161be28e7c4900572598fbb8c937ec

[Vickie Lynch]

Refs #9894 use FullInstrument instead of MINITOPAZ

Changeset: 946fb26e286480eb798c34928d64db5c0753d88e

[Vickie Lynch]

To test check times for running unit tests for AnvredCorrection, IntegratePeaksMD, IntegratePeaksMD2, CentroidPeaksMD, and CentroidPeaksMD2.

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/9894_Vickie_slow_unit_tests'

Full changeset: ​ec6f2edf5ec3bd1b683ad9bf735cf138ce610e4f

[Owen Arnold]

Good work. These tests are all below the threshold now.

[Stuart Campbell]

This ticket has been transferred to github issue ​10736