Slow Unit Tests for Alex Buts

[Owen Arnold]

We have a number of slow running unit tests which we need to fix as part of the 3.3 maintenance window. We are targeting test suits than execute in > 2 seconds on our clean rhel6 build servers. For IO tests (Loading & Saving) we have applied a more generous threshold of > 5 seconds.

See the full list to see which tests have been assigned to you: http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf

Criteria

1. Test suits (each test class instance) should execute in < 1 second as a rough target
2. As a corollary to the above, If the test suite contains lots of test methods aim for < 0.1 second per test method
3. If for some reason you get the speed up the test below the target using the strategies listed below, you need to justify why when you close the ticket.

Guidelines/instructions to help

1. Keep tests readable and improve code readability where possible. Unit tests are documentation.
2. Do not delete test methods without good reason. We do not want to reduce test coverage
3. Changing the algorithm code to improve speed is OK, but exercise caution. Add additional test coverage if it's not already good enough.
4. Take test methods that are slow and involve IO, or are processor intensive and make them into system tests. Integration tests are not Unit tests.
5. Most of the speed improvements will probably come from better selection of input data. Caching input data is also a good option.
6. Create sub tickets for algorithms or groups of algorithms to help testability if you wish, but mark this ticket as the 'blocked' by each one.

[Alex Buts]

refs #9895 This should fix ConvertToDiffractionMDWorkspace tests

The test is not written by me but just decreasing number of test points by two orders of magnitude do works without, seems, affecting the coverage.

Changeset: db3094375713062a406828ef97fbac139edbd423

[Alex Buts]

refs #9895 This should fix MaskPeaksWorkspaceTest

by creating source workspace with the same number of events as before.

Changeset: 13a2114ab15f37af5ca2e4141131faead0079b2a

[Alex Buts]

I've reduced the times for ConvertToMDDiffractionWorkspace2Test and ConvertToMDDiffractionWorkspaceTest to less then one second by decreasing the number of points to process.

As for ConvertToMDMinMaxGlobalTest and ConvertToMDMinMaxLocalTest, their execution times are in order of 20ms and I do not see how or where seconds may come from.

To test look at the test results and test execution time for any development build.

[Harry Jeffery]

Merge remote-tracking branch 'origin/bugfix/9895_SlowUT'

Full changeset: ​716362e2d5b1cfe05cb121ed021983c791f23b6e

[Stuart Campbell]

This ticket has been transferred to github issue ​10737