Ticket #9927 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Coverity - High Impact Outstanding issues in MantidPlot

Reported by: Michael Reuter Owned by: Samuel Jackson
Priority: critical Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

There are 19 Coverity high impact outstanding defects in the MantidPlot directory.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Owner changed from Nick Draper to Samuel Jackson
  • Status changed from new to assigned

feel free to share with Dan and Harry if you need to.

comment:2 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9927 Fix leaks in OPJFile.cpp

Changeset: 4a8022e11b2b97bf7e632a77545937c496910764

comment:3 Changed 6 years ago by Samuel Jackson

Refs #9927 Fix formatting.

Changeset: 191d24625904381bf5ee2ca28ed2bbab2541f38a

comment:4 Changed 6 years ago by Samuel Jackson

Refs #9927 Free buffer in Matrix.cpp

Changeset: d3acdd2ed1dede5a2f483ba4ee257cc61f84ce71

comment:5 Changed 6 years ago by Samuel Jackson

Refs #9927 Fix array size calculation in PatternBox.cpp

Changeset: 10f89a9b900effaecc824393a461023199d88be6

comment:6 Changed 6 years ago by Samuel Jackson

Refs #9927 Fix array size calculation in PenStyleBox.cpp

Changeset: b22997d29ce542fcb8bc63fb12234d72da82008c

comment:7 Changed 6 years ago by Samuel Jackson

Refs #9927 Fix array size calculation in SymbolBox.cpp

Changeset: 3df4ef3e637053c4547446f8c41c7fed0c37c578

comment:8 Changed 6 years ago by Samuel Jackson

Refs #9927 Fix array size calculation in ColorBox.cpp

Changeset: 878ecb96e81f3ec6a74a3b8d7f09add9c71ed184

comment:9 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

Code review to check the changes look like they should fix the issues listed under MantidPlot with my name attached.

​https://scan6.coverity.com:8443/reports.htm#v29905/p10083/fileInstanceId=16892974&defectInstanceId=5854522&mergedDefectId=528942

comment:10 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:11 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9927_mantidplot_coverity_issues'

Full changeset: ​c7754741a633ffe06a42f3af53fc47b2cf1d027b

comment:12 Changed 6 years ago by Anders Markvardsen

Read through code changes. A minor comment for future reference consider using c++ style casting instead of c-style casting, e.g. ​http://stackoverflow.com/questions/103512/in-c-why-use-static-castintx-instead-of-intx

comment:13 Changed 6 years ago by Samuel Jackson

That's a nice reference on the different types of cast in C++. Bookmarked for future reference. Thanks.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10769

Note: See TracTickets for help on using tickets.