Ticket #9933 (closed: fixed)
Add unit test to SaveGSS and convert input to histogram
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | |
| Cc: | petersonpf@… | Blocked By: | |
| Blocking: | Tester: | Karl Palmen |
Description (last modified by Wenduo Zhou) (diff)
Make a few improvements on SaveGSS
(1) Add unit tests to SaveGSS;
(2) Allow the input workspace has incomplete instrument, i.e., spectrum without detector, and treat it as a workspace without instrument;
(3) If the input workspace is DataPoint, give out a warning.
Change History
comment:2 Changed 6 years ago by Wenduo Zhou
Refs #9933. Made to support workspace without instrument better.
Changeset: efd716c61df0ee927394b518e0a9d87cf8e34e72
comment:3 Changed 6 years ago by Wenduo Zhou
Fixed a doxygen error. Refs #9933.
Changeset: 21f258fa41da2386bbd859e620884b413bfa1028
comment:4 Changed 6 years ago by Wenduo Zhou
Fixed a cppcheck error. Refs #9933.
Changeset: 4c37043eb10d8f529903a9c27d054785631e4480
comment:5 Changed 6 years ago by Wenduo Zhou
Fixed a sphinx error. Refs #9933.
Changeset: f3f99b259570539c50be29dc22dc4104c78cb316
comment:8 Changed 6 years ago by Wenduo Zhou
Added unit test for RALF. Refs #9933.
Changeset: 57eb236657d1e83fbb4462a29385979c107d2eb0
comment:9 Changed 6 years ago by Roman Tolchenov
Re #9933. Fixing the mac build
Changeset: 975923393ed06589a3eeb61ea753bb7316da3636
comment:10 Changed 6 years ago by Roman Tolchenov
Re #9933. Missed one.
Changeset: 4955f7f89fba6c8037c779b2bce06548e961924e
comment:11 Changed 6 years ago by Wenduo Zhou
Changed the naming convention back. Refs #9933.
Changeset: bbfa4a0ff1a3ac895614adfce18857764e616a05
comment:12 Changed 6 years ago by Wenduo Zhou
Try to fix a windows warning. Refs #9933.
Changeset: d9a8e04a7c5f3d4097929ecddc223f2261c46f4c
comment:13 Changed 6 years ago by Wenduo Zhou
Fixed some header issue. Refs #9933.
Changeset: 9c2494c152819e239d41d5aaaa752c59dea4c894
comment:14 Changed 6 years ago by Wenduo Zhou
Fix GEMTest. Refs #9933.
Changeset: 4c8ea4532b66abe18b5958bea9de8de79efbcf32
comment:15 Changed 6 years ago by Wenduo Zhou
Tried to fix a widows warning. Refs #9933.
Changeset: b4c24e53378c18f6b256e75f0445869367cea241
comment:17 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:18 Changed 6 years ago by Wenduo Zhou
For tester
You can check whether the unit tests and system tests pass.
comment:19 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:20 Changed 6 years ago by Karl Palmen
Unit and system tests have passed since the ticket was marked as fixed. Also a run of the algorithm went OK and code review shows unit tests added.
comment:21 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9933_savegss_improve'
Full changeset: cd59ee5531f85fc699aab4ce30110cbbe6763465
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10775
Added a unit test. Refs #9933.
Changeset: b1481b84e095b302e45127fb7c608daf8085abda