Ticket #9960 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

C2E: Use correct IDFs during reduction

Reported by: Samuel Jackson Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: #9699 Tester: Roman Tolchenov

Description (last modified by Samuel Jackson) (diff)

The energy transfer reduction (and presumably diffraction) do not play nice with older IDF files because they load an empty instrument which defaults to the most recent set of files.

This also causes an issue if the monitors for the older definition are different from the current definition.

Attachments

TFXA_Definition.xml​ (8.1 KB) - added by Samuel Jackson 6 years ago.
Example definition for testing.
TOSCA_Definition_TFXA.xml​ (8.2 KB) - added by Samuel Jackson 6 years ago.
XML file for testing
TOSCA_Parameters_TFXA.xml​ (2.3 KB) - added by Samuel Jackson 6 years ago.
XML For testing
TOSCA_Parameters_TFXA.2.xml​ (2.3 KB) - added by Samuel Jackson 6 years ago.
XML For testing

Change History

comment:1 Changed 6 years ago by Samuel Jackson

  • Description modified (diff)

comment:2 Changed 6 years ago by Samuel Jackson

Refs #9960 Use monitor index parameter from IDF.

Changeset: be88507882522b969f67530379dfc37247204e8d

comment:3 Changed 6 years ago by Samuel Jackson

Refs #9960 Update IPF files with monitor index.

Changeset: ae53d1c3f863122ed88022fce2354f486a17d462

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Samuel Jackson

To Test

  • Check system tests are passing
  • Check energy reduction runs with the correct IDF
    • Download the attached file and place it in your instrument directory.
    • Open Mantid and check you can search the data archive
    • Set the log level to debug
    • Open up Indirect Convert to Energy.
    • Choose instrument TOSCA
    • Type run number 00001
    • Change the spectrum range to be 1-36
    • Click run
    • Look at the debug log and check the supplied instrument definition was loaded
  • Repeat the above, but with a more recent run
Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:6 Changed 6 years ago by Samuel Jackson

  • Blocking 9699 added

Changed 6 years ago by Samuel Jackson

Example definition for testing.

comment:7 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Couldn't find file 00001. When running with 00002 didn't see TFXA_Definition.xml in the log.

Changed 6 years ago by Samuel Jackson

XML file for testing

Changed 6 years ago by Samuel Jackson

XML For testing

Changed 6 years ago by Samuel Jackson

XML For testing

comment:10 Changed 6 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

Apologies. I supplied the wrong XML file. Please place both

  • TOSCA_Definition_TFXA.xml
  • TOSCA_Parameters_TFXA.xml

In your instrument definition directory and follow the instructions above. Should also work with TSC0002 if you have that file instead.

comment:11 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:12 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:13 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to verify
  • Tester Roman Tolchenov deleted

comment:14 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

Looks like we need to solve some merge conflicts here.

comment:15 Changed 6 years ago by Martyn Gigg

  • Owner changed from Dan Nixon to Martyn Gigg

comment:16 Changed 6 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

Merge branch 'master' into feature/9960_legacy_IDF_reduction

Conflicts:

Code/Mantid/scripts/Inelastic/msg_reducer.py

Refs #9960

Changeset: fc7b065b712165174dedc36f07caaa822cef7209

comment:17 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:18 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:19 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge branch 'master' into feature/9960_legacy_IDF_reduction

Conflicts:

Code/Mantid/scripts/Inelastic/msg_reducer.py

Refs #9960

Full changeset: ​fc7b065b712165174dedc36f07caaa822cef7209

comment:20 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/9960_legacy_IDF_reduction'

Full changeset: ​b5d581627f6b3a1d06490760c01e75f80cc0eda9

comment:21 Changed 6 years ago by Samuel Jackson

Refs #9960 Use monitor index parameter from IDF.

Changeset: be88507882522b969f67530379dfc37247204e8d

comment:21 Changed 6 years ago by Samuel Jackson

Refs #9960 Use monitor index parameter from IDF.

Changeset: be88507882522b969f67530379dfc37247204e8d

comment:23 Changed 6 years ago by Samuel Jackson

Refs #9960 Update IPF files with monitor index.

Changeset: ae53d1c3f863122ed88022fce2354f486a17d462

comment:24 Changed 6 years ago by Samuel Jackson

Refs #9960 Update IPF files with monitor index.

Changeset: ae53d1c3f863122ed88022fce2354f486a17d462

comment:25 Changed 6 years ago by Martyn Gigg

Merge branch 'master' into feature/9960_legacy_IDF_reduction

Conflicts:

Code/Mantid/scripts/Inelastic/msg_reducer.py

Refs #9960

Changeset: fc7b065b712165174dedc36f07caaa822cef7209

comment:25 Changed 6 years ago by Martyn Gigg

Merge branch 'master' into feature/9960_legacy_IDF_reduction

Conflicts:

Code/Mantid/scripts/Inelastic/msg_reducer.py

Refs #9960

Changeset: fc7b065b712165174dedc36f07caaa822cef7209

comment:27 Changed 6 years ago by Martyn Gigg

Merge branch 'master' into feature/9960_legacy_IDF_reduction

Conflicts:

Code/Mantid/scripts/Inelastic/msg_reducer.py

Refs #9960

Full changeset: ​fc7b065b712165174dedc36f07caaa822cef7209

comment:27 Changed 6 years ago by Martyn Gigg

Merge branch 'master' into feature/9960_legacy_IDF_reduction

Conflicts:

Code/Mantid/scripts/Inelastic/msg_reducer.py

Refs #9960

Full changeset: ​fc7b065b712165174dedc36f07caaa822cef7209

comment:29 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/9960_legacy_IDF_reduction'

Full changeset: ​b5d581627f6b3a1d06490760c01e75f80cc0eda9

comment:30 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/9960_legacy_IDF_reduction'

Full changeset: ​b5d581627f6b3a1d06490760c01e75f80cc0eda9

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10802

Note: See TracTickets for help on using tickets.