Ticket #9990 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add background functions for PoldiCalculateSpectrum2D

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords: POLDI
Cc: Blocked By: #9445
Blocking: Tester: Dan Nixon

Description

In the original data analysis software a constant background and a background linear in 2-theta are added to the peaks.

For the constant background CurveFitting::FlatBackground should be okay, but for the 2-theta dependent part a function using the spectrum domain is required.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Michael Wedel

  • Status changed from assigned to inprogress

Refs #9990. Added linear background function for POLDI

A function that is linear in workspace index, as a background function for POLDI 2D-fits.

Changeset: 82ca548992b1594fd3a79daf97a1fe59e40fea24

comment:3 Changed 6 years ago by Michael Wedel

Refs #9990. Behavior of Poldi2DFunction now match CompositeFunction

Changeset: f72a7f1052b4b260319948cdaeae2c18c5e042ca

comment:4 Changed 6 years ago by Michael Wedel

Refs #9990. PoldiCalculateSpectrum2D now has background terms

Background functions are added if specified by the user.

Changeset: b63ca5a9f3cc33ddf4a81c246354fc6f7105aad3

comment:5 Changed 6 years ago by Michael Wedel

Refs #9990. Cleaning up.

Changeset: c0cb71b9e3731577e8668f6c89a2891338b851de

comment:6 Changed 6 years ago by Michael Wedel

Refs #9990. Removing debug output.

Changeset: c6643929c549320c964adb56e5acb4394a8f9957

comment:7 Changed 6 years ago by Michael Wedel

Refs #9990. Added algorithm properties to make testing easier.

Changeset: 1e7c9cecbfb238ea970d26c2b12850142838b23e

comment:8 Changed 6 years ago by Michael Wedel

Refs #9990. Added background example in documentation.

Changeset: 74765a7f9d92ec1cff115a106208be9419ef1956

comment:9 Changed 6 years ago by Michael Wedel

Refs #9990. Fixing unit test of Poldi2DFunction

Changed the behavior of PoldiSpectrumDomainFunction to be usable with CompositeFunction, had to adjust the unit test here to reflect that change.

Changeset: 4b9452d83f9c967e3ea427843a06466de9412edd

comment:10 Changed 6 years ago by Michael Wedel

Refs #9990. Fixing unit test of PoldiCalculateSpectrum2D

Forgot to include the composite function modifier in the tested string.

Changeset: f3703f240aa73cd55098951a6549758eb3e6b69b

comment:11 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing information

There is a new usage example on the wiki page that demonstrates the use of the background parameters. For manual tests the dialog (probably best after executing the usage example to have all the prerequisites available) can be used to alter the background parameters, the resulting spectrum should look similar to the second spectrum on the wiki page.

comment:12 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:13 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9990_poldi_2d_background_functions'

Full changeset: 563662e7dd8e6c7f06e65aada3136cd76b414d16

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10832

Note: See TracTickets for help on using tickets.