Remove usage of LoadInstrumentFromNexus from LoadMuonNexus

[Karl Palmen]

The usage of LoadInstrumentFromNexus in LoadMuonNexus has no effect in practice.

[Karl Palmen]

Remove call of LoadInstrumentFromNexus re #9996

Placeholder kept in comments

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 02e7b9aec34c773d7c2e0be06ca438e7e26c1bb8

[Karl Palmen]

To test, check that LoadInstrumentFromNexus works OK.

[Anders Markvardsen]

When I do a search for 'LoadInstrumentFromNexus' in 'Find in Files' I get 4 entries:

  C:\Backup\Backup_folder1\work\code\Mantid\git\mantid2\Code\Mantid\Framework\DataHandling\src\LoadMuonNexus.cpp(127):    /// Run the Child Algorithm LoadInstrument (or LoadInstrumentFromNexus)
  C:\Backup\Backup_folder1\work\code\Mantid\git\mantid2\Code\Mantid\Framework\DataHandling\src\LoadMuonNexus1.cpp(615):    /// Run LoadInstrumentFromNexus as a Child Algorithm (only if loading from instrument definition file fails)
  C:\Backup\Backup_folder1\work\code\Mantid\git\mantid2\Code\Mantid\Framework\DataHandling\src\LoadMuonNexus1.cpp(616):    void LoadMuonNexus1::runLoadInstrumentFromNexus(DataObjects::Workspace2D_sptr localWorkspace)
  C:\Backup\Backup_folder1\work\code\Mantid\git\mantid2\Code\Mantid\Framework\DataHandling\src\LoadMuonNexus1.cpp(621):      IAlgorithm_sptr loadInst = createChildAlgorithm("LoadInstrumentFromNexus");

The purpose of this ticket is to avoid using: (line 616 in LoadMuonNexus1)

      IAlgorithm_sptr loadInst = createChildAlgorithm("LoadInstrumentFromNexus");

and also remove any comments that indicates that LoadInstrumentFromNexus is used as part of loading a muon file

[Karl Palmen]

I missed out LoadMuonNexus1 completely.

[Karl Palmen]

Remove runLoadInstrumentFromNexus re #9996

and reference to LoadInstrumentFromNexus

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1be797b4367699c66faec2dbd7a153f6f844f903

[Anders Markvardsen]

Merge remote-tracking branch 'origin/feature/9996_load_instrument_form_nexus_removal'

Full changeset: ​18d4ac71e62c188b06d2e4c3255a681b72b76e76

[Anders Markvardsen]

muon loader no londer depends loadinstrumentfromnexus, which did not do anything in this case, and tested that could still load muon files as normal

[Stuart Campbell]

This ticket has been transferred to github issue ​10838