Ticket #11801 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Make system test OffspecSESANSP0 run on at least one platform

Reported by: Karl Palmen Owned by: Dan Nixon
Priority: major Milestone: Release 3.5
Component: Framework Keywords: maintenance
Cc: Blocked By:
Blocking: #11777 Tester: Federico Montesino Pouzols

Description


Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

(incorrect ticket number)

Last edited 5 years ago by Dan Nixon (previous) (diff)

comment:3 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

(incorrect ticket number)

Last edited 5 years ago by Dan Nixon (previous) (diff)

comment:4 Changed 5 years ago by Dan Nixon

Remove test no longer used

Refs #11801

Changeset: e4970771a64b01c930ffb9cdaa21e9632ff2555c

comment:5 Changed 5 years ago by Dan Nixon

This is being verified as ​pull request #770.

comment:6 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:7 Changed 5 years ago by Federico Montesino Pouzols

What the test OffspecSESANSP0 is testing from the missing/disappeared offspec module are the functions nrSESANSP0Fn and nrSESANSFn which now seem to be provided by scripts/Reflectometry/isis_reflectometry/procedures.py. Similarly, for PR #770, OffspecSESANSP0 tests nrSESANSP0Fn.

Who might be using those functions? So maybe we still want to keep this test? It would be nice to find someone who ever heard or remembers what these functions do. This looks a bit like an archeological task.

comment:8 Changed 5 years ago by Dan Nixon

@FedeMPouzols Well noticed, I did swap over the tests to use these functions but found that the isis_reflectometry/procedures.py script seems to be very out of date in it's use of the Python API.

Maybe @OwenArnold would know more about what the isis_reflectometry module is and if it is actually used/needed.

comment:9 Changed 5 years ago by Federico Montesino Pouzols

It definitely seems that this SESANS(P0) is not used any longer, so it should be safe to remove it. isis_reflectometry/procedures.py probably contains code that is superseded/abandoned/not used, and definitely not tested.

comment:10 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #769 from mantidproject/11801_remove_OffspecSESANS_test

Remove OffspecSESANS system test

Full changeset: ​2b7fa0a658aac560aabe31f23d315265ecfca9e9

comment:11 Changed 5 years ago by Federico Montesino Pouzols

This is a sibling of PF #769, it should be fine to remove this test.

comment:12 Changed 5 years ago by Federico Montesino Pouzols

Merge pull request #770 from mantidproject/11801_remove_OffspecSESANSP0_test

Remove OffspecSESANSP0 system test

Full changeset: ​ec60612cbaf5c4843b77782ce93e55bc15d2de7e

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12639

Note: See TracTickets for help on using tickets.