Ticket #1682 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create a KiKfCorrection algorithm

Reported by: Nick Draper Owned by: Andrei Savici
Priority: critical Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Nick Draper) (diff)

The algorithm should perform a Ki/Kf correction

Parameters

  • InputWorkspace
  • OutputWorkspace
  • EFixed (default empty)
  • EMode (List of "Direct","Indirect")

The algorithm should accept the value of EFixed if it is specified, if it is left blank it should interogate the workspace for the values. Efinal is stored as an instrument Parameter "EFixed" on each detector. Ei is stored in the run object "Ei". Obviously only one of these shold be present.

This ticket is associated with #1683 ensure you communicate with the owner when you are completed.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 10 years ago by Andrei Savici

(In [6887]) Initial version. refs #1682

comment:3 Changed 10 years ago by Andrei Savici

(In [6889]) Fixed test to remove event worspaces after test complete. refs #1682

comment:4 Changed 10 years ago by Andrei Savici

(In [7117]) cleaned source code. refs #1682

comment:5 Changed 10 years ago by Andrei Savici

  • Status changed from new to accepted

comment:6 Changed 10 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 10 years ago by Russell Taylor

(In [7135]) Make thread-safe and cache references to data outside tight loop. Re #1682.

comment:8 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Tested on MARI on windows and on MERLIN on Redhat. Seems to give sensible results.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2529

Note: See TracTickets for help on using tickets.