Ticket #1839 (closed: fixed)
Cut/Copy/Paste shortcuts in Script Interpreter don't work when another window is open
Reported by: | Michael Whitty | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | MantidPlot | Keywords: | Student,Challenging |
Cc: | Blocked By: | ||
Blocking: | Tester: | Vickie Lynch |
Description (last modified by Samuel Jackson) (diff)
related to #1061
If another is open within mantid plot, the Ctrl+C (copy), Ctrl+V(paste) and Ctrl+X(cut) shortcuts do not seem to work within the script interpreter.
This is the case for plots, and data views (matrix workspaces). It does not seem to be the case when the other window is a custom interface.
Change History
comment:1 Changed 10 years ago by Nick Draper
- Owner set to Sofia Antony
- Status changed from new to assigned
comment:2 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:3 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:5 Changed 10 years ago by Sofia Antony
(In [9684]) re#1839 - The problem was commands like Ctrl+C on script interpreter is routed to global editing command handlers in Application window. Added code to handle Ctrl+C on script widget in the application window copySelection() method.
Application window copySelection() handles copy actions on all windows of type MDISubWindow in Mantidplot and if any of these windows is kept opened and a Ctrl+C on script interpreter widget the command was getting routed to application window code. Fixed this.However when I do paste command (Ctrl+V shortcut ) on script interpreter it gives an error -conflicting Ctrl+V shortcut Need to fix this.
comment:6 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:7 Changed 9 years ago by Nick Draper
- Status changed from accepted to new
- Owner Sofia Antony deleted
Taken from Sofia Antony's list after she left
comment:10 Changed 9 years ago by Russell Taylor
Last check-in should have been under #3139.
comment:11 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
"New" tickets moved at the code freeze of iteration 29
comment:12 Changed 9 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Anyone
comment:13 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:14 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:15 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:16 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:17 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:18 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:19 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:24 Changed 7 years ago by Samuel Jackson
Fixed bug with cut, copy and paste commands.
Pressing the command key was forcing the editor to deselect text and move the cursor to the end of the line.
Refs #1839
Changeset: 84e1cf920035c1a0d63ec18c6fe373765ed2eaf4
comment:25 Changed 7 years ago by Samuel Jackson
Fixed bug with backspace.
Backspace was not properly deleting selected text if the selection went up to the start of the editable line.
Refs #1839
Changeset: 792468130a05cfdfe8d32687f3836cf3946fc38a
comment:26 Changed 7 years ago by Samuel Jackson
- Status changed from accepted to verify
- Resolution set to fixed
- Description modified (diff)
Appears to be working correctly now.
To Test:
1) Open Mantid and hit F4 to bring up the script interpreter.
2) Type something (can be anything)
3) Hit return. Now you should be on a new line.
4) Try cutting and copying text using the keyboard commands (not right click!) and pasting it into the current line.
5) Also try highlighting the whole of the editable line and hitting backspace to delete its contents. This should now work.
6) Get creative: Perhaps try cutting/copying/pasting text using the keyboard commands to/from a separate editor. Try highlighting more than just the last line of text and hitting backspace (should not delete anything).
comment:27 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:28 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
It doesn't work for me (on RHEL6) specifically in the case where there's a non-floating graph and I try Ctrl-V or Ctrl-C.
Note that this is with what I consider to be referred to by 'Script Interpreter' - the one you get via F4 not F3 (the Script Window) as the testing instructions mention.
comment:29 Changed 7 years ago by Samuel Jackson
Yes, I meant the script interpreter. Got the keyboard short cut wrong. It should be F4. I'll edit the testing outline.
comment:30 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Adding code to terminate pasting if an error is encountered.
Refs #1839
Changeset: 96e03fcec04956d5adc3557297f7aea5847355de
comment:31 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
Had a problem with not being able to fix on specific RHEL machines. Created ticket #7508 to deal with this problem and pushed the fix for other platforms before the 2.6 code freeze.
comment:32 Changed 7 years ago by Vickie Lynch
On my Rhel6 machine, the copy, cut, paste worked in both the script interpreter and python window. Also I copied a non-floating graph with ctrl-C and was able to paste in a document with ctrl-V. I was not able to paste it back into MantidPlot after I deleted it, but I could still paste to other applications.
comment:33 Changed 7 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester changed from Russell Taylor to Vickie Lynch
comment:35 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2686