Ticket #2816 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Fix problems when using gcc 4.6

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: critical Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Stuart Campbell) (diff)

A number of the framework tests fail and MantidPlot itself fails to compile.

Change History

comment:1 Changed 9 years ago by Stuart Campbell

  • Status changed from new to accepted
  • Owner set to Stuart Campbell
  • Description modified (diff)
  • Summary changed from MantidPlot fails to compile with gcc 4.6 to Fix problems when using gcc 4.6

comment:2 Changed 9 years ago by Stuart Campbell

(In [11062]) Small fix to compile under gcc 4.6 refs #2816

comment:3 Changed 9 years ago by Stuart Campbell

At the moment I get the following tests to fail... 

	102 - GeometryTest_RulesCompObjTest (Failed)
	 94 - GeometryTest_ParObjComponentTest (Failed)
	 88 - GeometryTest_ObjectTest (Failed)
	 87 - GeometryTest_ObjComponentTest (Failed)
	204 - DataHandlingTest_LoadInstrumentFromRawTest (Failed)
	397 - CrystalTest_LoadPeaksFileTest (Failed)

comment:4 Changed 9 years ago by Stuart Campbell

Due to a change in behaviour in istringstream::tellg() which now sets the eofbit when you reach the end of a string. In our 'implementation' this causes the tellg() to return a -1 and therefore falls over.

We probably need a detailed look at our string handling and low level geometry parsing... but that's for another day.

comment:5 Changed 9 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12042]) Just clear the error flag on reaching the eof(). Better solution is needed, but this fixes the problem for now. fixes #2816

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Fedora 15 uses gcc 4.6, ​http://fedoraproject.org/wiki/Releases/15/FeatureList, and we seem to be compiling and testing everything on that platform so I'd say that's fine.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3663

Note: See TracTickets for help on using tickets.