Cancel button does not work in Plot details

[Steve Williams]

1. Load any data
2. Plot any spectrum of this data
3. Right click over plot and select 'Properties..'
4. Change e.g. Canvas Color
5. Hit the Cancel button

And changes still applied even though Cancel button was hit

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Anders Markvardsen]

Estimated to take 2 man days

[Karl Palmen]

Does anyone know which code deals with the properties dialog box that has the failing cancel button?

[Karl Palmen]

The dialog box is called Plot Details in the wiki http://www.mantidproject.org/MantidPlot:_Plot_Details

[Karl Palmen]

I see that the dialog box has a Geometry tab in addition to the default Layer tab. In the Geometry tab the change does not take effect till the apply button is pressed after which the cancel button will not undo the change. Whereas the change has immediate effect in the Layer tab without need to press the apply button.

[Karl Palmen]

This raises the issue of what the "Apply", "Cancel" and other such buttons should do in any dialog box in MantidPlot. Consistency would be desireable.

[Nick Draper]

Moved to iteration 33 at iteration 32 code freeze

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

http://www.mantidproject.org/Release_Notes_2_2_Full_List

[Nick Draper]

Moved to milestone 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Moved to the Backlog after the code freeze for R2.6

[Jay Rainey]

Reformatted code to abide by mantid styleguide. Refs #3464

Changeset: 4b2b9aa47f5907225748d7067c4a5a1011748c20

[Jay Rainey]

Apply and cancel button now function as expected. Refs #3464

Changeset: 35c0ef66fc23c1e1a46b7a0cd19395388757fc45

[Jay Rainey]

Removed unused slots. Refs #3464.

Changeset: 46a67fb303da87615950f7d5d30900106b3d8cd8

[Jay Rainey]

Removed duplicate code. Refs #3464."

Accidently forgot to remove code when refactoring.

Changeset: aed2fa3cc39869c7bcabe4db32c17a4320700f2d

[Jay Rainey]

The problem was that when a user wanted to change the properties of a plot they could click the relevant button and this would automagically apply the change. This was not the desired effect as it is inconsistent with other interfaces within Mantid.

The Apply & Cancel buttons now work as expected. That is, the user can select multiple changes to be made, then apply them if they wish, otherwise cancel and no change would be made.

[Jay Rainey]

To test:

1. Load any data (CSP79590.raw for example)
2. Right click in workspace and left click Plot spectrum...
3. Right click over plot and select 'Properties..'
4. Change something (E.g. Background color)
   • You should now have to click apply for these changes to be seen.
5. Change something else and press Cancel
   • The change you wanted to make should now not have taken place.

Ensure this functionality is persistent throughout the user interface.

[Jay Rainey]

Reformatted code to abide by mantid styleguide. Refs #3464

Changeset: 4b2b9aa47f5907225748d7067c4a5a1011748c20

[Jay Rainey]

Apply and cancel button now function as expected. Refs #3464

Changeset: 35c0ef66fc23c1e1a46b7a0cd19395388757fc45

[Jay Rainey]

Removed unused slots. Refs #3464.

Changeset: 46a67fb303da87615950f7d5d30900106b3d8cd8

[Jay Rainey]

Removed duplicate code. Refs #3464."

Accidently forgot to remove code when refactoring.

Changeset: aed2fa3cc39869c7bcabe4db32c17a4320700f2d

[Russell Taylor]

Mostly, that's much better but there are a few that have been missed:

• If you have a line plot and check the 'Fill area under curve' box in the line tab it's applied immediately (see PlotDialog.cpp line 933).
• If you have symbols and (un)check the 'Fill Color' box/
• Changing error bar widths on a plot from a qtiplot table
• Pie chart settings (although I doubt anyone ever creates one of those)
• The Percentile tab settings (create a box plot from a qtiplot table - that must be even rarer)

Basically look for anywhere acceptParams() is called. The first 2 are the ones that matter.

[Jay Rainey]

Checkboxes should not false on startup. Refs #3464.

Changeset: d4e423a98505ec2e20b85ccdfc661d29c4a07afe

[Jay Rainey]

Removed unnecessary methods related to error menu GUI. Refs #3464.

Changeset: 9d7ea57784ac4a0e728d2e0cd9b8f0b96dbc33d7

[Jay Rainey]

Fixed pie chart settings. Refs #3464.

Changeset: 4e3b117a834af3fb1ffbfc3809315d8264c814cc

[Jay Rainey]

Fixed percentile tab. Refs #3464.

Changeset: ae136522b3b2cef2306f03c75a2e1a670c34067d

[Jay Rainey]

In order to test this, see ​above, and also Russell's ​reply to ensure all interface features are consistent and work as expected.

[Russell Taylor]

Everything that I checked now worked correctly.

[Stuart Campbell]

This ticket has been transferred to github issue ​4311