Ticket #4538 (closed: fixed)
Rename the qti MantidPlot python module to _qti
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | MantidPlot | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Janik Zikovsky |
Description (last modified by Russell Taylor) (diff)
This is the module containing all the MantidPlot functions exposed via sip.
Now that proxy objects have been added in #1037, people - in particular end-users - should not be using this module directly. We can't actually prevent people from doing so, but we can give a strong hint (to those who are familiar with python) by changing the name of the module to start with an underscore.
Also intend to revert certain things so that people can again type 'import mantidplot' rather than 'import mantidplotpy'.
Change History
comment:1 Changed 9 years ago by Russell Taylor
- Status changed from new to accepted
- Description modified (diff)
comment:2 Changed 9 years ago by Russell Taylor
Go back to 'import mantidplot' rather than 'mantidplotpy'. Re #4538.
Move mantidplot.py back up next to the executable to avoid the clunky workaround and have a more obvious module name.
Changeset: 00a7b5793ed1829f5b4859498e30e67adaadd791
comment:3 Changed 9 years ago by Russell Taylor
Revert "Change import of mantidplot to mantiplotpy in applicable places."
This reverts commit 432e2fdac4a93c0203110982b768eb4a50af2f2a (Re #1037) Back to mantidplot again. Re #4538.
Changeset: 7c9601a1b51e265adb26a07aa6b1cf64ffff8eab
comment:4 Changed 9 years ago by Russell Taylor
Revert "re #4402 changed references of mantidplot to mantidplotpy"
This reverts commit d076cce3f6963e17e60f409c3c0ff41d884297d3. Back to 'import mantidplot' again. Re #4538.
Changeset: 2f58d5a8c14143cf6c58024aca8285b6616e987f
comment:5 Changed 9 years ago by Russell Taylor
Rename the qti MantidPlot python module to _qti. Re #4538.
To give a strong hint to users that it should not be used directly. Everything should go through the mantidplot module instead (see mantidplot.py). Think I caught all the places it's used.
Changeset: ca7ad35cd5a6adce49b36c1b7eb072ae0a1c1bdb
comment:6 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 9 years ago by Russell Taylor
Go back to 'import mantidplot' rather than 'mantidplotpy'. Re #4538.
Move mantidplot.py back up next to the executable to avoid the clunky workaround and have a more obvious module name.
Changeset: 00a7b5793ed1829f5b4859498e30e67adaadd791
comment:8 Changed 9 years ago by Russell Taylor
Revert "Change import of mantidplot to mantiplotpy in applicable places."
This reverts commit 432e2fdac4a93c0203110982b768eb4a50af2f2a (Re #1037) Back to mantidplot again. Re #4538.
Changeset: 7c9601a1b51e265adb26a07aa6b1cf64ffff8eab
comment:9 Changed 9 years ago by Russell Taylor
Revert "re #4402 changed references of mantidplot to mantidplotpy"
This reverts commit d076cce3f6963e17e60f409c3c0ff41d884297d3. Back to 'import mantidplot' again. Re #4538.
Changeset: 2f58d5a8c14143cf6c58024aca8285b6616e987f
comment:10 Changed 9 years ago by Russell Taylor
Rename the qti MantidPlot python module to _qti. Re #4538.
To give a strong hint to users that it should not be used directly. Everything should go through the mantidplot module instead (see mantidplot.py). Think I caught all the places it's used.
Changeset: ca7ad35cd5a6adce49b36c1b7eb072ae0a1c1bdb
comment:11 Changed 9 years ago by Mathieu Doucet
Re #4538 recovering...
Changeset: 5e24e8539221c78e9c67d1912fbfdf564883ed08
comment:12 Changed 9 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
comment:13 Changed 9 years ago by Janik Zikovsky
- Status changed from verifying to closed
import _qti and import mantidplot work.
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5385
