Ticket #4609 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Second and third Q-axis captions are probably wrong for non-reclinear lattices

Reported by: Alex Buts Owned by: Andrei Savici
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: saviciat@… Blocked By: #4813
Blocking: Tester: Michael Reuter

Description (last modified by Alex Buts) (diff)

ConvertToMDevents currently convert to orthogonal attached to reciprocal lattice system of coordinates which has first vector (u) direction selected accordingly to the hkl coordinates of the reciprocal lattice (e.g. [1,1,0], second vector (v) -- in the plain defined by its hkl coordinates but orthogonal to the first one [e.g. [1,-1,1] and the third -- orthogonal to the first two.

This has been done because the visualization displays the images in orthogonal coordinate system, when hkl do not generally relate to orthogonal system for non-cubic Bravais cell not

The captions along the axis in HKL coordinate system are currently made by symbolic representation of the above mentioned indexes. e.g, for the example above, we would have X-axis caption [Qh,Qk,0] and Y-axis-- [Qh,-Qk,Ql]

when the first axis is certainly directed where the caption says, two other axis are probably not if the Bravais cell is not rectangular.

Despite current Mslice and Horace are doing something similar, this is probably wrong.

Change History

comment:1 Changed 9 years ago by Alex Buts

  • Description modified (diff)

comment:2 Changed 9 years ago by Alex Buts

refs #4609 Small test to check that the axis captions are correct

for at least an rectangular lattice (To Andrei to verify)

Changeset: 868b42bc26eec821042d83d2c8e0305ca23673d5

comment:3 Changed 9 years ago by Alex Buts

refs #4609 Small test to check that the axis captions are correct

for at least an rectangular lattice (To Andrei to verify)

Changeset: 868b42bc26eec821042d83d2c8e0305ca23673d5

comment:4 Changed 9 years ago by Andrei Savici

  • Status changed from new to assigned
  • Owner set to Andrei Savici

comment:5 Changed 9 years ago by Andrei Savici

  • Status changed from assigned to accepted

comment:6 Changed 9 years ago by Alex Buts

refs #4609 Removed debugging code from UnitCell.cpp

Changeset: a3054a137f43dee296c974a89868c580dbba0924

comment:7 Changed 9 years ago by Alex Buts

  • Blocked By 4813 added

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.1

comment:10 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

Works for now. Need more testing for forced orthogonal axes

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:12 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

Sat with Garrett and verified that everything is in the expected locations and looks correct.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5456

Note: See TracTickets for help on using tickets.