Ticket #4841 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

[C2E / IDA] - Move parameter(s) from Py code to istrument definition file.

Reported by: Peter Parker Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.0
Component: MantidPlot Keywords: C2E IDA
Cc: spencer.howells@… Blocked By:
Blocking: #7870 Tester: Alex Buts

Description

Where values have been hard-coded and would benefit from being in parameter files, move them there.

Change History

comment:1 Changed 9 years ago by Peter Parker

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Peter Parker

  • Summary changed from [C2E] - Move parameter(s) from Py code to istrument definition file. to [C2E / IDA] - Move parameter(s) from Py code to istrument definition file.

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:5 Changed 8 years ago by Peter Parker

  • Keywords C2E IDA added

comment:6 Changed 8 years ago by Dereck Kachere

  • Owner changed from Peter Parker to Dereck Kachere

comment:7 Changed 8 years ago by Dereck Kachere

  • Status changed from accepted to assigned

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:9 Changed 8 years ago by Dereck Kachere

  • Milestone changed from Release 2.4 to Release 2.5

comment:10 Changed 7 years ago by Dereck Kachere

  • Cc spencer.howells@… added

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:13 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:14 Changed 7 years ago by Samuel Jackson

  • Owner changed from Dereck Kachere to Samuel Jackson

comment:15 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Updated to move attenuation to instrument definition file.

Refs #4841

Changeset: eb5b93f88c29cc99da6e55766e78ee09d28e4ee9

comment:16 Changed 7 years ago by Samuel Jackson

I'm going to mark this as fixed. Both me and Spencer have had a look there don't seem to be any obvious cases in the python code that need moving. In ticket #7870 the interface needs to be changed to use the values in the IPF/IDFs. If we've missed any they will most likely become obvious as we try to use them in the GUI.

To Tester

Run though a reduction and creating a resolution file using indirect instruments (IRIS, OSIRIS and TOSCA) to check that moving attenuation to rely on the IDF works correctly.

Additionally, check that the following system tests are passing:

  • ISISIndirectInelastic
  • IndirectDiffractionTests
Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:17 Changed 7 years ago by Samuel Jackson

Updated OSIRIS and IRIS parameter files.

Refs #4841

Changeset: b6db6963ace74af3dc44bef47d760b8076559dfd

comment:18 Changed 7 years ago by Samuel Jackson

Swapped HandleMonitor to use new parameters.

Refs #4841

Changeset: 535013228c04c8de86e3dc926e3bf0f7f7c390d6

comment:19 Changed 7 years ago by Samuel Jackson

Correcting TOSCA parameters to be consistent with the others.

Refs #4841

Changeset: 038fa2ce0a2bd770276552063d271a44a258d826

comment:20 Changed 7 years ago by Samuel Jackson

Refs #4841 Update unit test to count new attenuation parameter.

Changeset: 6f76f8c2a0f35c5e63cbee921f75254bd776e4a0

comment:21 Changed 7 years ago by Samuel Jackson

Correcting Monitor Scaling parameter and instrument IDs.

Refs #4841

Changeset: bcb38c950d9471849c04ab4b59040ea4adcbe2ab

comment:22 Changed 7 years ago by Samuel Jackson

Refs #4841 Updating LoadRaw3Test to count (another) additional parameter.

Changeset: c101ba351b03cc2fb8848d30c07a1b69b3b948fd

comment:23 Changed 7 years ago by Samuel Jackson

Refs #4841 Update for TOSCA diffraction parameters

Changeset: d75759dc62edc95f418939f9213907a77f67baf0

comment:24 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:25 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:26 Changed 7 years ago by Samuel Jackson

  • Blocking 7870 added

comment:27 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:28 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/4841_params_from_py_to_IDF'

Full changeset: ​e31a24b005fd17460719f7caf20d94a490ff5ad5

comment:29 Changed 7 years ago by Alex Buts

there are some places where parameters are still predefined in the scripts, but these are left on Spencer's requests.

system tests pass

default facility in Mantid.user.properties prevents from finding instrument from another facility -- the issue substantially complicated testing this ticket.

comment:30 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/4841_params_from_py_to_IDF'

Full changeset: ​7143289d0d39828b851731a2445ffcfc84bd5a17

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5688

Note: See TracTickets for help on using tickets.