Ticket #5056 (closed: worksforme)

Opened 9 years ago

Last modified 5 years ago

Refactor and improve event filtering

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Peter Peterson

Description (last modified by Wenduo Zhou) (diff)

FilterByLogValue, FilerByTime and FilterEventsHighFrequency have some of their functionality in redundancy. On the other hand, the filtering capability provided by these algorithms cannot satisfy the users. Refactor and improvement from these algorithms are required.

A splitter class will be created to unify the filtering algorithm.

Per Andrei's request

  1. Add progress bar to 'FilterEvents' and 'GenerateEventsFilter';
  2. Add information to each output workspace of 'FilterEvents';
  3. Add increase/decrease/both tag to information workspace from 'GenerateEventsFilter';
  4. Group output workspaces of 'FilterEvents' as an option.

Change History

comment:1 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to accepted
  • Owner set to Wenduo Zhou

comment:2 Changed 9 years ago by Wenduo Zhou

Add SplittersWorkspace. Refs #5056.

Add (1) abstract class ISplittersWorkspace for python. (2) SplitterWorkspace inheriting from TableWorkspace.

Changeset: 4e8c127edb1d84d446264d788026b44dc0273d87

comment:3 Changed 9 years ago by Wenduo Zhou

Minor change in inheritance. Refs #5056.

Changeset: e976d3e6a1d9aff4f8eca191144f43441bb917fe

comment:4 Changed 9 years ago by Wenduo Zhou

Enhance TimeSplitterType. Refs #5056.

Changeset: 016626ee4125499439c0d6b7a46e4c7decf2790a

comment:5 Changed 9 years ago by Roman Tolchenov

Re #5056. VC dosn't think that size_t is unsigned long

Changeset: cc6bd8d2f3465233ca3c861265333464248cde98

comment:6 Changed 8 years ago by Wenduo Zhou

Implementing FilterEvents and etc. Refs #5056.

  1. Add algorithm FilterEvents to filter events from SplittersWorkspace
  2. Add but not finish algorithm GenerateEventsFilter to support

FilterEvents

  1. Enhance EventList, SplittersWorkspace, WorkspaceCreationHelper to

support the new algorithms.

Changeset: afbcfd9be63a3687841cc7523d0dddd19b2fbc70

comment:7 Changed 8 years ago by Wenduo Zhou

Implement GenerateEventFilter. Refs #5056.

Implemented algorithm GenerateEventsFilte, including unit test. Some related classes are modified accordingly.

Changeset: 8c41b0eb47986300bbef97f8e1c4fe8e3cc328e1

comment:8 Changed 8 years ago by Wenduo Zhou

Continue to refactor events filtering. Refs #5056.

(1) Using GenerateEventsFilter() and FilterEvents() to refactor FilterByTime. (2) Clean the codes of GenerateEventsFilter and FilterEvents.

Changeset: 60562799dfb88c39ad915c9a516b28019642360a

comment:9 Changed 8 years ago by Wenduo Zhou

Implement GenerateEventFilter. Refs #5056.

Implemented algorithm GenerateEventsFilte, including unit test. Some related classes are modified accordingly.

Changeset: 8c41b0eb47986300bbef97f8e1c4fe8e3cc328e1

comment:10 Changed 8 years ago by Wenduo Zhou

Continue to refactor events filtering. Refs #5056.

(1) Using GenerateEventsFilter() and FilterEvents() to refactor FilterByTime. (2) Clean the codes of GenerateEventsFilter and FilterEvents.

Changeset: 60562799dfb88c39ad915c9a516b28019642360a

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:12 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:13 Changed 8 years ago by Wenduo Zhou

Enhance event filtering. Refs #5056.

Changeset: 44d547c1da08a4579836414a9efda633103fe377

comment:14 Changed 8 years ago by Wenduo Zhou

Some more features for FilterEvents. Refs #5056."

New features include

  1. Add progress bar
  2. Option to group all output workspaces
  3. Add workspace information to each workspace's comment. Changeset: 289fa09350f55f4b7a6dfea468414d52a2185a45

comment:15 Changed 8 years ago by Wenduo Zhou

Enhance event filtering. Refs #5056.

Changeset: 44d547c1da08a4579836414a9efda633103fe377

comment:16 Changed 8 years ago by Wenduo Zhou

Some more features for FilterEvents. Refs #5056."

New features include

  1. Add progress bar
  2. Option to group all output workspaces
  3. Add workspace information to each workspace's comment. Changeset: 289fa09350f55f4b7a6dfea468414d52a2185a45

comment:17 Changed 8 years ago by Wenduo Zhou

Enhance event filtering. Refs #5056.

Changeset: 44d547c1da08a4579836414a9efda633103fe377

comment:18 Changed 8 years ago by Wenduo Zhou

Some more features for FilterEvents. Refs #5056."

New features include

  1. Add progress bar
  2. Option to group all output workspaces
  3. Add workspace information to each workspace's comment. Changeset: 289fa09350f55f4b7a6dfea468414d52a2185a45

comment:19 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:21 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Return to Wenduo

comment:22 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:23 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:24 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to worksforme

comment:25 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester changed from Vickie Lynch to Peter Peterson

comment:26 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

This was in the last stable release of mantid. Since it has been in users hands for three months it either works or new tickets were created.

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5902

Note: See TracTickets for help on using tickets.