MUON: Using graph toolbar doesn't allow you to fit afterwards.

[Robert Whitley]

If you use zoom on a data set and then try and fit using the muon fit property browser it won't allow you.

This is because zooming and other graph options disconnects the peak picker tool.

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

Moved at the end of release 2.2

[Nick Draper]

Moved to milestone 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Robert's old tickets returned to you for assessment.

Are they still valid, duplicates?

[Nick Draper]

Robert's old tickets returned to you for assessment.

Are they still valid, duplicates?

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Anders Markvardsen]

To reproduce do:

1. Plot any muon data from MuonAnalysis

2. Select Data Analysis tab

3. Add say a flat background

4. Say rigth click on figure and chose Reset range

5. Then click on e.g. the magnification icon at the top

The fit focus with the graph is lost

[Arturs Bekasovs]

Removed fitPropBrowser parameter from fittingRequested signal and renamed it.

fitPropBrowser will be set using different signal.

Refs #5116

Changeset: ca00f39caf72cd13a08025faca241acdf148e7b7

[Arturs Bekasovs]

Refactored activatePPTool so it goes through window list only once.

Removed irrelevant warning.

Refs #5116

Changeset: d53a63a520441e225a5321870ee687329ce81e23

[Arturs Bekasovs]

Added a possibility to change the used fit property browser.

Refs #5116

Changeset: 100119aed5a0029123c3dccd28d33041f01bfd3a

[Arturs Bekasovs]

A new method to get the name of the custom interface.

Refs #5116

Changeset: a9d8f34e61311ec32b6933ec4b6ae0b45ed8329d

[Arturs Bekasovs]

Changing used fit property browser to Muon one, when interface is launched.

And resetting to default when is closed.

Refs #5116

Changeset: b4e058e0a516224d3a3e964963e8c431d83f9455

[Arturs Bekasovs]

Replaced the old signal used in the previous ticket

Refs #5116

Changeset: 135eef77e6267946b7999bafc5418b5913ab8166

[Arturs Bekasovs]

Made it so that Muon fit property browser is used only if we are on the DA tab.

Refs #5116

Changeset: 0708b7f859d6031c9551c55499aa89d0d09bad4e

[Arturs Bekasovs]

Removed the usage of the old values for new PP tool.

Automatic ones are used, as everywhere. This didn't make sense when using graph tools, e.g. zoom.

Refs #5116

Changeset: 91a0c974d3c00874e2df800ed56a5e02d2534a8f

[Arturs Bekasovs]

The problem described in a ticket happens using the standard PP tool with all the MantidPlot plots. The reason for that is that graph buttons are mutually exclusive. So if one is pressed another can't be, i.e. if you are zooming you can't fit. However, using the standard tools you can then click the PP tool button and the PP tool appears again. This was not possible with Muon Analysis, as PP tool was enabled only when we entered the Data Analysis tab.

So after speaking to Roman and Anders I have decided to solve the problem by connecting the PP tool button to the Muon fit property browser when we are on the Data Analysis tab. So if you are on the DA tab and you zoom in, you can now click the PP tool button and PP will appear again. Before that clicking on PP tool would launch the standard fit browser on the left, which is probably not what users expect.

[Arturs Bekasovs]

Tester:

In a few words the thing which should be tested: "If we are in the Muon interface Data Analysis tab, the Muon fit property browser should be used instead of the default one, and all the buttons should react appropriately."

1. Open Muon Analysis interface.

2. Click "Browse..." button to load a file. Use the Muon one, e.g. AutoTestData/MUSR00015189.nxs.

3. Then make a plot using a "Plot" button, if it was not done automatically.

4. Focus on the plot window, and press "Select Multiple Peaks" button at the top of the MantidPlot. As we are not on the Data Analysis tab, the standard fit property browser should open on the left, and the blue range selectors should appear on the active plot. Make sure it works as expected.

5. Now go to the Data Analysis tab. Plot might get redrawn, but the blue range selectors should still be on the graph and the "Select Multiple Peaks" button should be still pressed.

6. Zoom in using one of the standard tools. Blue range selector lines should disappear, and "Select Multiple Peaks" should be released. This is expected behavior.

7. Now press the "Select Multiple Peaks" button again, and make sure that peak selector appears and when range is changed, it affects the values in Muon analysis fit property browser and not in default one.

8. Close the Muon interface (or just leave the Data Analysis tab), and make sure that now fit uses default property browser again.

9. Try switching to Data Analysis tab while PP tool is active. This should reassign property browser correctly.

[Arturs Bekasovs]

Reopened to fix a compiler warning about the unused parameter.

​https://builds.sns.gov/job/ornl_clean_rhel6_develop/2127/warnings17Result

[Arturs Bekasovs]

Removed unused parameter from the constructor.

Refs #5116

Changeset: 8d60a1053427809fce411cc9196a3e0ca69932de

[Anders Markvardsen]

Behaviour is now that when going to Data Analysis tab that window moves as discussed

[Arturs Bekasovs]

Change the sequence of init methods called.

Some of the interfaces are hacking around with initLocalPython, which causes problems when it is run before setGeometry.

Refs #5116

Changeset: 72add4f6fa48c48f6d731515658be3ae7a6f7706

[Arturs Bekasovs]

Change the sequence of init methods called.

Some of the interfaces are hacking around with initLocalPython, which causes problems when it is run before setGeometry.

Refs #5116

Changeset: 72add4f6fa48c48f6d731515658be3ae7a6f7706

[Arturs Bekasovs]

(In #7874) Need #5116 changes from to get here so setFitFunctionBrowser appears, and I no longer need to specify Fit Browser for fittingRequested and can use selectMultiPeak from Python. So pausing with this one till it happens.

[Arturs Bekasovs]

The problem discussed (plot being redrawn when not needed) will get solved along with other such Muon Analysis problems in #7887. Meanwhile, there is another problem observed - when we plot something on the Home tab so that connected graph changes, and then go to DA tab, multiple workspace get plotted instead of a new one, so I will solve this one and close the ticket.

[Arturs Bekasovs]

Solved the problem with plotting multiple times when going to DA tab.

Solution - only enable auto-update when ws list was refreshed, as the plotShow was called multiple times while list is filled.

Refs #5116

Changeset: c03124669fff2451ce3cc4cc713ddb08c1cabb8b

[Arturs Bekasovs]

Revert some potentially dangerous changes which are not needed anymore.

Refs #5116

Changeset: 646e644a53608c2976ee1e189b6039810875bafe

[Arturs Bekasovs]

No need to remove PP tool on interface start. Plus documentation clean-up.

Refs #5116

Changeset: 6082055f997d503443e385ef1f7c02f51955a329

[Arturs Bekasovs]

Make N/A text to be consistent.

Refs #5116

Changeset: d0a560c3e685f172cfa42331e2954ce1581d3c0e

[Arturs Bekasovs]

Single function to set connected data name.

Refs #5116

Changeset: 4ea04c7c99ab9ed0b2d3370ba8455f285ee9d1ec

[Arturs Bekasovs]

Deal with situations when there are not workspaces available.

Refs #5116

Changeset: ad477d0acff4e3d7ebeed9e4bc5c80071f230557

[Arturs Bekasovs]

Need to merge conflicts.

[Anders Markvardsen]

looks good you can now switch between the MuonAnalysis fittting and the mantidplot fitting and the correction fit function toolbox becomes active

[Anders Markvardsen]

Merge remote-tracking branch 'origin/feature/5116_fit_with_graph_toolbar'

[Stuart Campbell]

This ticket has been transferred to github issue ​5962