Ticket #5361 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Give unique tube names in MERLIN IDF

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: critical Milestone: Release 2.1.1
Component: Mantid Keywords: PatchCandidate,Released
Cc: karl.palmen@… Blocked By:
Blocking: Tester: Nick Draper

Description


Change History

comment:1 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Cc karl.palmen@… added

comment:2 Changed 8 years ago by Anders Markvardsen

Give unique tube names in MERLIN IDF. . re #5361

Changeset: 803e331468ac0233b7bf013b1f53914e115ef654

Last edited 8 years ago by Nick Draper (previous) (diff)

comment:3 Changed 8 years ago by Anders Markvardsen

Give unique tube names in MERLIN IDF. re #5361

Changeset: 803e331468ac0233b7bf013b1f53914e115ef654

Last edited 8 years ago by Nick Draper (previous) (diff)

comment:4 Changed 8 years ago by Karl Palmen

Put missing space characters into MERLIN_Definition.xml re #5361

This is needed for it to display the instrument and instrument tree correctly

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0c0b6fddd8db6c806cc95c9f02a3a37af94e5d48

comment:5 Changed 8 years ago by Nick Draper

  • Keywords PatchCandidate added

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.1.1

Moved for inclusion in the 2.1.1 patch

comment:7 Changed 8 years ago by Anders Markvardsen

Give unique tube names in MERLIN IDF. PatchCandidate. re #5361

Changeset: 156b22e91aee49d914aea65dfc066d3fab92f6cf

comment:8 Changed 8 years ago by Karl Palmen

Put missing space characters into MERLIN_Definition.xml re #5361

This is needed for it to display the instrument and instrument tree correctly

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0ecca1b938f2838eca52f99df7d32339d937273c

comment:9 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test

  1. Load any MERLIN data set or use LoadEmptyInstrument to load MERLIN_Instrument.xml
  1. In instrument view notice that the tubes now are labelled tube 1, etc

comment:10 Changed 8 years ago by Karl Palmen

Put missing space characters into MERLIN_Definition.xml re #5361

This is needed for it to display the instrument and instrument tree correctly

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0c0b6fddd8db6c806cc95c9f02a3a37af94e5d48

comment:11 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

door3 tubes have repeated names

comment:13 Changed 8 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Karl Palmen
  • Status changed from reopened to assigned

comment:14 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:15 Changed 8 years ago by Karl Palmen

Change tube names to show pack number re #5361

This also results in the tube names becoming unique. The two digits in the tube name now match the 2nd and 3rd digits of the detector IDs of its pixels.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e320469de3226ab0f8f21a796ec3c09a539ffd3c

comment:16 Changed 8 years ago by Karl Palmen

Put missing space characters into MERLIN_Definition.xml re #5361

This is needed for it to display the instrument and instrument tree correctly

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0c0b6fddd8db6c806cc95c9f02a3a37af94e5d48

comment:17 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:18 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Nick Draper

comment:19 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

comment:20 Changed 8 years ago by Karl Palmen

Change tube names to show pack number re #5361

This also results in the tube names becoming unique. The two digits in the tube name now match the 2nd and 3rd digits of the detector IDs of its pixels.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0f9c659507cf25085807f3faa58b414882842651

comment:21 Changed 8 years ago by Karl Palmen

Change tube names to show pack number re #5361

This also results in the tube names becoming unique. The two digits in the tube name now match the 2nd and 3rd digits of the detector IDs of its pixels.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0f9c659507cf25085807f3faa58b414882842651

comment:22 Changed 8 years ago by Karl Palmen

Change tube names to show pack number re #5361

This also results in the tube names becoming unique. The two digits in the tube name now match the 2nd and 3rd digits of the detector IDs of its pixels.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0f9c659507cf25085807f3faa58b414882842651

comment:23 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6207

Note: See TracTickets for help on using tickets.