Ticket #5743 (closed: fixed)
More changes to SNSPowderReduction
Reported by: | Vickie Lynch | Owned by: | Vickie Lynch |
---|---|---|---|
Priority: | major | Milestone: | Release 2.3 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description (last modified by Vickie Lynch) (diff)
EditInstrumentGeometry is still done inside python SNSPowderReduction. Focus positions should be sent to C++ AlignAndFocusPowder to do this. Also this is python algorithm with mixed new and old api, so change everything to new api.
Attachments
Change History
comment:3 Changed 8 years ago by Vickie Lynch
- Description modified (diff)
- Summary changed from Table of focus postions for AlignAndFocusPowder to More changes to SNSPowderReduction
comment:4 Changed 8 years ago by Vickie Lynch
Refs #5743 converted to new api
Changeset: 7abfb49e436dbd82bcde0a3d1b520777341444bd
comment:5 Changed 8 years ago by Vickie Lynch
Refs #5743 EditInstrumentGeometry inside AlignAndFocusPowder
Changeset: 732b7eea759a43c15f57b31bc375b24d6667264e
comment:6 Changed 8 years ago by Vickie Lynch
Refs #5743 validators work in new api
Changeset: ac850a5cac417710280bd67784bfaa229ff84fcc
comment:7 Changed 8 years ago by Vickie Lynch
Refs #5743 remove _focus
Changeset: 22aeba9aae22ba3002c3c3634f48399e4c7b4c96
comment:8 Changed 8 years ago by Vickie Lynch
Refs #5743 do not call getProperty for every chunk
Changeset: d702ad154b37822c1f4809e7d789a0c2ef23be7e
comment:9 Changed 8 years ago by Vickie Lynch
Refs #5743 add iparamFile
Changeset: 22598c59f179c35632527f928addb0761791a285
comment:10 Changed 8 years ago by Vickie Lynch
Refs #5743 omit CropWorkspace if no events
Changeset: bad093b91b6191b29b12d2c3d16209a547ae31b8
comment:11 Changed 8 years ago by Vickie Lynch
Refs #5743 use short name for files from calFile
Changeset: 774e1041d13d1a683f56d7e571a2f267e9deba2f
comment:12 Changed 8 years ago by Vickie Lynch
Refs #5743 converted to new api
Changeset: 7abfb49e436dbd82bcde0a3d1b520777341444bd
comment:13 Changed 8 years ago by Vickie Lynch
Refs #5743 EditInstrumentGeometry inside AlignAndFocusPowder
Changeset: 732b7eea759a43c15f57b31bc375b24d6667264e
comment:14 Changed 8 years ago by Vickie Lynch
Refs #5743 validators work in new api
Changeset: ac850a5cac417710280bd67784bfaa229ff84fcc
comment:15 Changed 8 years ago by Vickie Lynch
Refs #5743 remove _focus
Changeset: 22aeba9aae22ba3002c3c3634f48399e4c7b4c96
comment:16 Changed 8 years ago by Vickie Lynch
Refs #5743 do not call getProperty for every chunk
Changeset: d702ad154b37822c1f4809e7d789a0c2ef23be7e
comment:17 Changed 8 years ago by Vickie Lynch
Refs #5743 omit CropWorkspace if no events
Changeset: bad093b91b6191b29b12d2c3d16209a547ae31b8
comment:18 Changed 8 years ago by Vickie Lynch
Refs #5743 add iparamFile
Changeset: 22598c59f179c35632527f928addb0761791a285
comment:19 Changed 8 years ago by Vickie Lynch
Refs #5743 use short name for files from calFile
Changeset: 774e1041d13d1a683f56d7e571a2f267e9deba2f
comment:20 Changed 8 years ago by Vickie Lynch
Refs #5743 already existing workspace converted to correct units
Changeset: f20322cadb9426b150ac4e36e7dead2297709160
Changed 8 years ago by Vickie Lynch
- Attachment SNSPowderReduction2.pyc added
SNSPowderReduction before changes
Changed 8 years ago by Vickie Lynch
- Attachment SNSPowderReduction2.py added
SNSPowderReduction before changes
comment:21 Changed 8 years ago by Vickie Lynch
- Status changed from accepted to verify
- Resolution set to fixed
Passes SystemTests with changes
comment:22 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:23 Changed 8 years ago by Russell Taylor
- Status changed from verifying to closed
No sign of EditInstrumentGeometry in SNSPowderReduction an longer. Old python API stuff (i.e. MantidFramework) also absent. SNSPowderRedux system test passes locally for me once I'd got hold of the files.
comment:24 Changed 8 years ago by Vickie Lynch
Refs #5743 already existing workspace converted to correct units
Changeset: f20322cadb9426b150ac4e36e7dead2297709160
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6589