SANS: Support flood correction file for each detector

[Gesner Passos]

The Flood Correction File that is being used now in LOQ and SANS2D works only for the MAIN/REAR detector. There is plan in SANS2D to create a new one for the FRONT detector. This means that the AnalysisDetails tab must change in order to support this, and the UserFile must also support new entry as well.

The suggestion is, split the flood file into front and rear detectors and have two check boxes, which can be independently applied as needed.

So instead of having, for example, a User file command MON/FLAT=MANTID_FLAT_CELL.115 we have: MON/FLAT/REAR = 'file' MON/FLAT/FRONT = 'file'

Observed when testing #5844. Note: #5844 ticket make the flood file to be ignored for the front/hab detectors. This might be changed in this ticket.

[Gesner Passos]

Flood file correction for MAIN detector.

[Nick Draper]

Moved at the code freeze for release 2.4

[Gesner Passos]

Implement the support for FLOOD file for FRONT detectors

• SANSRunWindow.ui: add two file widgets to pass the FLOOD FILE.

• SANSRunWindow.cpp: adapt this class to deal with two FLOOD FILE.

• isis_reduction_steps.py:
  • Override the setPixelCorrFile of CalculateNorm in order to accept flood files for FRONT and REAR detectors.
  • Work around the calculate method, in order to passe to CalculareNorm the correct _pixel_file to execute the pixel dependend correction.
  • Implement the parser for the user file to accept the new commands: MON/FLAT/[REAR/FRONT].

• ISISCommandInterface.py:
  • Adapt the SetDetectorFloodFile function to the new setPixelCorrFile.
  • Remove the ​changeset that put to ignore the FLOOD file for Front detectors.

• ISISCommandInterface.py: Adapt the SetDetectorFloodFile to support the new setPixelCorrFile method.

• isis_instrument.py:
  • Add two methods that provide a way to access the detectors bank independently from their names (which is confusin, because SANS2D uses different names from LOQ)
  • Solve a problem with crop_to_workspace that was causing the HAB FLOOD file to break because it was trying to crop mixing the definition of workspace index and spectrum indexes.

re #6061

Changeset: 50278206eea7da80ee512bc087a15d59f0a26158

[Gesner Passos]

Remove useless warning that is not valid any more

Now we support FLOOD file for HAB.

re #6061

Changeset: 0e0b904d3bc65701c915d2d663116beb1f7a404c

[Gesner Passos]

Bring back the user file parsing

Some system tests breaks with the previous one.

re #6061

Changeset: cafd701aa21fdebfe122c4b59106daf585d561a7

[Gesner Passos]

Correct issues regarding the FindCentre algorithm

re #6061

Changeset: d526a6b57893c19105041e292496951106644fe9

[Gesner Passos]

Tester:

• Open SANS INTERFACE
• Select LOQ instrument
• Load User file: ​MASK.CENTER
• Make sure the files ​MANTID_FLAT_CELL_MAIN.115 ​MANTID_FLAT_CELL_HAB.115 ​DIRECT.041.txt and ​DIRECTHAB.983.txt are available for Mantid. Download all to the same folder and set the User directories to look to this path (I recomend putting it at the first entry of your User directories)
• Set Sample 74466 (cycle_12_4)
• Apply Load
• Run 1D Reduction
• Switch ON/OFF the options AnalysisDetails tab (Rear flood file, front flood file)
• Switch ON/OFF this options through MON/FLAT/[FRONT|REAR] options at UserFile
• Ensure that the reduction is done as expected.

[Gesner Passos]

The previous one had incorrect dimensions

[Gesner Passos]

data required from masked.center

[Gesner Passos]

data required from masked.center hab

[Roman Tolchenov]

It didn't work for me.

[Gesner Passos]

This code was implemented before the new git workflow. So the code is already inside the Mantid master branch. It is only necessary to test the ticket to see if is working. Hopefully, nothing is needed to be added.

[Gesner Passos]

Stephen King has found that givin a value (-1 or 0) that is considered the values for masked detectors cause the reduction to raise an exception:

Error in execution of algorithm Q1D:
Instrument: Detector with ID 16735 not found. search object

You can see this using the MANTID_FLAT_CELL_FRONT.131 as flood file.

I will update the test to use this file as default.

[Gesner Passos]

New flood file that caused exception raised by Stephen

[Gesner Passos]

User File for new datasets

[Gesner Passos]

Correct the validation of Pixel Adjusting

re #6061

Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe

[Gesner Passos]

branch: feature/6061_flood_hab

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Karl Palmen]

Unable to run python script in http://www.mantidproject.org/Checking_the_Flood_File_works , because I could not find the files there.

[Roman Tolchenov]

Works without crash with the old and new flood files.

[Gesner Passos]

Correct the validation of Pixel Adjusting

re #6061

Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Gesner Passos]

Correct the validation of Pixel Adjusting

re #6061

Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Gesner Passos]

Correct the validation of Pixel Adjusting

re #6061

Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Gesner Passos]

Correct the validation of Pixel Adjusting

re #6061

Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Gesner Passos]

Correct the validation of Pixel Adjusting

re #6061

Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe

[Gesner Passos]

Real correction the validation of Pixel Adjusting

last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.

re #6061

Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef

[Stuart Campbell]

This ticket has been transferred to github issue ​6907