Ticket #6061 (closed: fixed)
SANS: Support flood correction file for each detector
Reported by: | Gesner Passos | Owned by: | Gesner Passos |
---|---|---|---|
Priority: | major | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | anders.markvardsen@… | Blocked By: | |
Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Gesner Passos) (diff)
The Flood Correction File that is being used now in LOQ and SANS2D works only for the MAIN/REAR detector. There is plan in SANS2D to create a new one for the FRONT detector. This means that the AnalysisDetails tab must change in order to support this, and the UserFile must also support new entry as well.
The suggestion is, split the flood file into front and rear detectors and have two check boxes, which can be independently applied as needed.
So instead of having, for example, a User file command MON/FLAT=MANTID_FLAT_CELL.115 we have: MON/FLAT/REAR = 'file' MON/FLAT/FRONT = 'file'
Observed when testing #5844. Note: #5844 ticket make the flood file to be ignored for the front/hab detectors. This might be changed in this ticket.
Attachments
Change History
Changed 8 years ago by Gesner Passos
- Attachment MANTID_FLAT_CELL_MAIN.115 added
comment:1 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:4 Changed 8 years ago by Gesner Passos
Implement the support for FLOOD file for FRONT detectors
- SANSRunWindow.ui: add two file widgets to pass the FLOOD FILE.
- SANSRunWindow.cpp: adapt this class to deal with two FLOOD FILE.
- isis_reduction_steps.py:
- Override the setPixelCorrFile of CalculateNorm in order to accept flood files for FRONT and REAR detectors.
- Work around the calculate method, in order to passe to CalculareNorm the correct _pixel_file to execute the pixel dependend correction.
- Implement the parser for the user file to accept the new commands: MON/FLAT/[REAR/FRONT].
- ISISCommandInterface.py:
- Adapt the SetDetectorFloodFile function to the new setPixelCorrFile.
- Remove the changeset that put to ignore the FLOOD file for Front detectors.
- ISISCommandInterface.py: Adapt the SetDetectorFloodFile to support the new setPixelCorrFile method.
- isis_instrument.py:
- Add two methods that provide a way to access the detectors bank independently from their names (which is confusin, because SANS2D uses different names from LOQ)
- Solve a problem with crop_to_workspace that was causing the HAB FLOOD file to break because it was trying to crop mixing the definition of workspace index and spectrum indexes.
re #6061
Changeset: 50278206eea7da80ee512bc087a15d59f0a26158
comment:5 Changed 8 years ago by Gesner Passos
Remove useless warning that is not valid any more
Now we support FLOOD file for HAB.
re #6061
Changeset: 0e0b904d3bc65701c915d2d663116beb1f7a404c
comment:6 Changed 8 years ago by Gesner Passos
Bring back the user file parsing
Some system tests breaks with the previous one.
re #6061
Changeset: cafd701aa21fdebfe122c4b59106daf585d561a7
comment:7 Changed 8 years ago by Gesner Passos
Correct issues regarding the FindCentre algorithm
re #6061
Changeset: d526a6b57893c19105041e292496951106644fe9
comment:8 Changed 8 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
Tester:
- Open SANS INTERFACE
- Select LOQ instrument
- Load User file: MASK.CENTER
- Make sure the files MANTID_FLAT_CELL_MAIN.115 MANTID_FLAT_CELL_HAB.115 DIRECT.041.txt and DIRECTHAB.983.txt are available for Mantid. Download all to the same folder and set the User directories to look to this path (I recomend putting it at the first entry of your User directories)
- Set Sample 74466 (cycle_12_4)
- Apply Load
- Run 1D Reduction
- Switch ON/OFF the options AnalysisDetails tab (Rear flood file, front flood file)
- Switch ON/OFF this options through MON/FLAT/[FRONT|REAR] options at UserFile
- Ensure that the reduction is done as expected.
comment:9 Changed 8 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
Changed 8 years ago by Gesner Passos
- Attachment MANTID_FLAT_CELL_HAB.115 added
The previous one had incorrect dimensions
Changed 8 years ago by Gesner Passos
- Attachment DIRECT.041.txt added
data required from masked.center
Changed 8 years ago by Gesner Passos
- Attachment DIRECTHAB.983.txt added
data required from masked.center hab
comment:10 Changed 8 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
It didn't work for me.
comment:12 Changed 8 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
This code was implemented before the new git workflow. So the code is already inside the Mantid master branch. It is only necessary to test the ticket to see if is working. Hopefully, nothing is needed to be added.
comment:13 Changed 8 years ago by Gesner Passos
- Status changed from verify to reopened
- Resolution fixed deleted
comment:14 Changed 8 years ago by Gesner Passos
Stephen King has found that givin a value (-1 or 0) that is considered the values for masked detectors cause the reduction to raise an exception:
Error in execution of algorithm Q1D: Instrument: Detector with ID 16735 not found. search object
You can see this using the MANTID_FLAT_CELL_FRONT.131 as flood file.
I will update the test to use this file as default.
Changed 8 years ago by Gesner Passos
- Attachment MANTID_FLAT_CELL_FRONT.131 added
New flood file that caused exception raised by Stephen
comment:15 Changed 8 years ago by Gesner Passos
Correct the validation of Pixel Adjusting
re #6061
Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe
comment:16 Changed 8 years ago by Gesner Passos
- Status changed from reopened to accepted
branch: feature/6061_flood_hab
comment:17 Changed 8 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
comment:18 Changed 8 years ago by Gesner Passos
- Status changed from verify to reopened
- Resolution fixed deleted
comment:20 Changed 8 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:21 Changed 8 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:22 Changed 8 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
comment:23 Changed 8 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester changed from Roman Tolchenov to Karl Palmen
comment:24 Changed 8 years ago by Karl Palmen
- Status changed from verifying to verify
- Tester Karl Palmen deleted
Unable to run python script in http://www.mantidproject.org/Checking_the_Flood_File_works , because I could not find the files there.
comment:25 Changed 8 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:26 Changed 8 years ago by Roman Tolchenov
- Status changed from verifying to closed
Works without crash with the old and new flood files.
comment:27 Changed 8 years ago by Gesner Passos
Correct the validation of Pixel Adjusting
re #6061
Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe
comment:28 Changed 8 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:29 Changed 8 years ago by Gesner Passos
Correct the validation of Pixel Adjusting
re #6061
Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe
comment:30 Changed 8 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:31 Changed 8 years ago by Gesner Passos
Correct the validation of Pixel Adjusting
re #6061
Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe
comment:32 Changed 8 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:33 Changed 7 years ago by Gesner Passos
Correct the validation of Pixel Adjusting
re #6061
Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe
comment:34 Changed 7 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:35 Changed 7 years ago by Gesner Passos
Correct the validation of Pixel Adjusting
re #6061
Changeset: c2db799c438cda32563b21ac0547d4fc3977e2fe
comment:36 Changed 7 years ago by Gesner Passos
Real correction the validation of Pixel Adjusting
last commit introduced a bug instead of correcting. Now, only exceptions related to no detector associated is ignored.
re #6061
Changeset: bbc3e38748aa6ad35143a96d22048ac33dd911ef
comment:37 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6907
Flood file correction for MAIN detector.