Ticket #6083 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create interconnected description of LeBailFit group of algorithms

Reported by: Alex Buts Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description (last modified by Wenduo Zhou) (diff)

LeBailFit is currently not one but number of algorithms, which depends on each other, e.g. LeBailFit itself needs data prepared in specific format provided by another algorithm. References to the LeBailFit desigh/descrtiption documentation have to be provided on/available from WIKI

The use of the algorithms is seems also depends on understanding the LeBailFit technique

There is specific terminology, which requests description or references to web resources. e.g. number of terms is used in input table workspace (Dtt1,Dtt2,Dtt1t... etc.) They have to be either described in the algorithm description or referred to on the web, not forcing a user search through the FullProf website and reading whole FullProf manual to understand what is going on.

The scripts, provided for the testing of the tickets #5858 and #5306 should be available as examples with detailed description of data formats used or the references to these formats on the web.

The purpose of this ticket is to provide a user who has basic understanding of LeBailFit method with all tools to provide his own fitting.

Test for LeBailFit group of algorithms

It makes more sense to test the group of algorithms related to Le Bail fit together, because they are designed to work together to calibrate powder diffratometer's instrument profile parameters.

About the test

The attached python script for test follows the workflow to calibrate the instrument profile parameters of a powder diffratometer from a measure of LaB6.

The testing script covers the following algorithms:

  • CreateLeBailFitInput;
  • FitPowderDiffPeaks in robust mode;
  • LeBailFit in calculation mode;
  • LeBailFit in Monte Carlo mode;
  • ProcessBackground;
  • RefinePowderInstrumentParameters

How to test

Download the attached Python script ticket6083test.py from this ticket. The data file, PG3_11485-1.dat, can be found in systemtests/data/. The powder reflection file, LB4844b1.hkl, and Fullprof resolution file, 2011B_HR60b1.irf, can be downloaded from here too.

Attachments

2011B_HR60b1.irf (987 bytes) - added by Wenduo Zhou 8 years ago.
LB4844b1.hkl (22.1 KB) - added by Wenduo Zhou 8 years ago.
ticket6083test.py (4.8 KB) - added by Wenduo Zhou 8 years ago.

Change History

comment:1 Changed 8 years ago by Alex Buts

  • Description modified (diff)

comment:2 Changed 8 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 8 years ago by Alex Buts

  • Description modified (diff)

comment:4 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Wenduo Zhou

Remove unused data file. Refs #6017 and #6083.

Changeset: 2e8387c180cb0c963b34eaf4c94bd8e7a8efa2bd

comment:6 Changed 8 years ago by Wenduo Zhou

Remove unused data file. Refs #6017 and #6083.

Changeset: 2e8387c180cb0c963b34eaf4c94bd8e7a8efa2bd

comment:7 Changed 8 years ago by Wenduo Zhou

Remove unused data file. Refs #6017 and #6083.

Changeset: f33d93c377e1b322eeaf9264ccd23122b82a952a

comment:8 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:9 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:10 Changed 8 years ago by Wenduo Zhou

Add data set for test. Refs #6083.

Changeset: 2004a91cbf1b6e613ba27004427ced66fd00a61e

Changed 8 years ago by Wenduo Zhou

Changed 8 years ago by Wenduo Zhou

Changed 8 years ago by Wenduo Zhou

comment:11 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:12 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:13 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

The interconnected description of all Le Bail fit related algorithms is made in the wiki page of LeBailFit?.

comment:14 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:15 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

I am not an expert in Le-Bail fit but things seems work.

Minor remarks would be to brush-up the description (e.g. Optimization --> ...such as Simplex or -- the sentences hangs nowhere, and I do not know what to add there) and add more links and test descriptions. (e.g. sample 10 in FullProf says me nothing despite I've installed FullProf and tried to find where it is)

I have added the test script provided for the ticket testing as the example of the method which is useful starting point.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6929

Note: See TracTickets for help on using tickets.