Ticket #6552 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

More algorithms using workspace name when they should be using the pointer

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description (last modified by Russell Taylor) (diff)

Following on from #5864, a grep on getPropertyValue\(\.*Workspace returns the following, many of which should probably be using the workspace pointer instead of the name: 

Algorithms/src/BinaryOperation.cpp:          pow->setPropertyValue("OutputWorkspace", this->getPropertyValue("OutputWorkspace"));
Algorithms/src/BinaryOperation.cpp:          mult->setPropertyValue("OutputWorkspace", this->getPropertyValue("OutputWorkspace"));Algorithms/src/CalculateTransmissionBeamSpreader.cpp:    std::string outputWSName = getPropertyValue("OutputWorkspace");
Algorithms/src/CalculateTransmission.cpp:    std::string outputWSName = getPropertyValue("OutputWorkspace");
Algorithms/src/ChangeLogTime.cpp:    msg << "InputWorkspace \'" << this->getPropertyValue("InputWorkspace")
Algorithms/src/CheckWorkspacesMatch.cpp:  WorkspaceGroup_sptr ws1 = boost::dynamic_pointer_cast<WorkspaceGroup>(dataStore.retrieve(getPropertyValue("Workspace1")));
Algorithms/src/CheckWorkspacesMatch.cpp:  WorkspaceGroup_sptr ws2 = boost::dynamic_pointer_cast<WorkspaceGroup>(dataStore.retrieve(getPropertyValue("Workspace2")));
Algorithms/src/ChopData.cpp:  const std::string output = getPropertyValue("OutputWorkspace");
Algorithms/src/CloneWorkspace.cpp:    alg->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
Algorithms/src/ConjoinWorkspaces.cpp:  AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
Algorithms/src/ConjoinWorkspaces.cpp:  AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace1"));
Algorithms/src/ConjoinWorkspaces.cpp:  AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
Algorithms/src/ConjoinWorkspaces.cpp:  declareProperty(new WorkspaceProperty<>("Output",getPropertyValue("InputWorkspace1"),Direction::Output));
Algorithms/src/ConjoinWorkspaces.cpp:  if (retval) AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
Algorithms/src/CorrectToFile.cpp:    g_log.error() << "Correction file " << getPropertyValue("Filename") + " can't be used to correct workspace " << getPropertyValue("WorkspaceToCorrect") << std::endl;
Algorithms/src/CreateFlatEventWorkspace.cpp:     // std::string outputWsName = this->getPropertyValue("OutputWorkspace");
Algorithms/src/CreateLogPropertyTable.cpp:    const std::string outputTableName = this->getPropertyValue("OutputWorkspace");
Algorithms/src/CreateWorkspace.cpp:  std::string parentWorkspace = getPropertyValue("ParentWorkspace");
Algorithms/src/CreateWorkspace.cpp:  if (!parentWS || !getPropertyValue("WorkspaceTitle").empty())
Algorithms/src/DetectorDiagnostic.cpp:      std::string maskName = this->getPropertyValue("OutputWorkspace");
Algorithms/src/DiffractionFocussing2.cpp:  bool inPlace = (this->getPropertyValue("InputWorkspace") == this->getPropertyValue("OutputWorkspace"));
Algorithms/src/FFTDerivative.cpp:    //  std::string name = getPropertyValue("OutputWorkspace");
Algorithms/src/GetTimeSeriesLogInformation.cpp:	if (!getPropertyValue("OutputWorkspace").empty())
Algorithms/src/Qhelper.cpp:  std::string baseName = alg->getPropertyValue("OutputWorkspace");
Algorithms/src/RayTracerTester.cpp:    alg->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
Algorithms/src/RenameWorkspace.cpp:  std::string outputwsName = getPropertyValue("OutputWorkspace");
Algorithms/src/RenameWorkspace.cpp:  if (getPropertyValue("InputWorkspace") == getPropertyValue("OutputWorkspace"))
Algorithms/src/RenameWorkspace.cpp:  std::string outputwsName = getPropertyValue("OutputWorkspace");
Algorithms/src/SassenaFFT.cpp:  const std::string gwsName = this->getPropertyValue("InputWorkspace");
Algorithms/src/ShiftLogTime.cpp:      msg << "InputWorkspace \'" << this->getPropertyValue("InputWorkspace")
Algorithms/src/StripVanadiumPeaks2.cpp:    std::string outputWSName = getPropertyValue("OutputWorkspace");
API/src/WorkspaceOpOverloads.cpp:            alg->getPropertyValue("OutputWorkspace"));
Crystal/src/AnvredCorrection.cpp:  bool inPlace = (this->getPropertyValue("InputWorkspace") == this->getPropertyValue("OutputWorkspace"));
Crystal/src/LoadIsawPeaks.cpp:    ws->setName(getPropertyValue("OutputWorkspace"));
Crystal/src/SCDCalibratePanels.cpp:    string PeakWSName = getPropertyValue( "PeakWorkspace");
Crystal/src/SCDCalibratePanels.cpp:    std::string ResultWorkspaceName= getPropertyValue( "ResultWorkspace");
Crystal/src/SCDCalibratePanels.cpp:   std::string QErrorWorkspaceName = getPropertyValue("QErrorWorkspace");
Crystal/src/SCDCalibratePanels.cpp:     string PeakWSName = getPropertyValue("PeakWorkspace");
CurveFitting/src/Old_Fit.cpp:    std::string input = "WorkspaceIndex=" + getPropertyValue("WorkspaceIndex");
DataHandling/src/LiveDataAlgorithm.cpp:    if (this->getPropertyValue("OutputWorkspace").empty())
DataHandling/src/LiveDataAlgorithm.cpp:      if (this->getPropertyValue("AccumulationWorkspace").empty())
DataHandling/src/LiveDataAlgorithm.cpp:      if (this->getPropertyValue("AccumulationWorkspace") == this->getPropertyValue("OutputWorkspace"))
DataHandling/src/LiveDataAlgorithm.cpp:      std::string outName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LiveDataAlgorithm.cpp:      std::string accumName = this->getPropertyValue("AccumulationWorkspace");
DataHandling/src/LiveDataAlgorithm.cpp:          if (!accumName.empty() && alg->getPropertyValue("AccumulationWorkspace") == accumName)
DataHandling/src/LiveDataAlgorithm.cpp:          if (alg->getPropertyValue("OutputWorkspace") == outName)
DataHandling/src/LoadCalFile.cpp:    std::string WorkspaceName = getPropertyValue("WorkspaceName");
DataHandling/src/LoadDAE.cpp:              Workspace_sptr ws = AnalysisDataService::Instance().retrieve(getPropertyValue("OutputWorkspace"));
DataHandling/src/LoadDetectorInfo.cpp:    g_log.warning() << "Note workspace " << getPropertyValue("Workspace") << " has been changed so if you intend to fix detector mismatch problems by running "
DataHandling/src/LoadEventNexus.cpp:  std::string outName = getPropertyValue("OutputWorkspace");
DataHandling/src/LoadISISNexus2.cpp:        const std::string base_name = getPropertyValue("OutputWorkspace") + "_";
DataHandling/src/LoadLiveData.cpp:      std::string inputName = "__anonymous_livedata_input_" + this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadLiveData.cpp:        inputName = this->getPropertyValue("AccumulationWorkspace");
DataHandling/src/LoadLiveData.cpp:        outputName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadLiveData.cpp:        g_log.error() << "Something really wrong happened when adding " << inputName << " to ADS. " << this->getPropertyValue("OutputWorkspace") << std::endl;
DataHandling/src/LoadLiveData.cpp:      if (this->getPropertyValue("AccumulationWorkspace").empty())
DataHandling/src/LoadLiveData.cpp:      std::string outputName = "__anonymous_livedata_convert_" + this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadNexus.cpp:      m_workspace = getPropertyValue("OutputWorkspace");
DataHandling/src/LoadNexusProcessed.cpp:    std::string base_name = getPropertyValue("OutputWorkspace");
DataHandling/src/LoadRawHelper.cpp:        std::string wsName= getPropertyValue("OutputWorkspace");
DataHandling/src/LoadSassena.cpp:  const std::string gwsName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadSassena.cpp:  const std::string gwsName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadSassena.cpp:  const std::string gwsName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/MonitorLiveData.cpp:    std::string AccumulationWorkspace = this->getPropertyValue("AccumulationWorkspace");
DataHandling/src/MonitorLiveData.cpp:    std::string OutputWorkspace = this->getPropertyValue("OutputWorkspace");
DataHandling/src/SaveNexus.cpp:    saveNexusPro->setPropertyValue("WorkspaceIndexList", getPropertyValue("WorkspaceIndexList"));
DataHandling/src/SaveNexus.cpp:    saveNexusPro->setPropertyValue("WorkspaceIndexMax", getPropertyValue("WorkspaceIndexMax"));
DataHandling/src/SaveNexus.cpp:    saveNexusPro->setPropertyValue("WorkspaceIndexMin", getPropertyValue("WorkspaceIndexMin"));
DataHandling/src/SaveRKH.cpp:    << " Workspace: " << getPropertyValue("InputWorkspace") << "\n";
DataHandling/src/SetScalingPSD.cpp:    //m_workspace = getPropertyValue("Workspace");
MDAlgorithms/src/BinaryOperationMD.cpp:      clone->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
MDAlgorithms/src/CloneMDWorkspace.cpp:    std::string outWSName = getPropertyValue("OutputWorkspace");
MDAlgorithms/src/CreateMDFitWorkspace.cpp://        std::string fname = "C:/Users/hqs74821/Work/InstrumentBug/" + getPropertyValue("OutputWorkspace") + ".csv";
MDAlgorithms/src/MergeMD.cpp:    AnalysisDataService::Instance().addOrReplace(this->getPropertyValue("OutputWorkspace"), out);
MDAlgorithms/src/MergeMDFiles.cpp:    loader->setPropertyValue("OutputWorkspace", this->getPropertyValue("OutputWorkspace") );
MDAlgorithms/src/SetMDUsingMask.cpp:      clone->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
MDAlgorithms/src/TransformMD.cpp:      clone->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
MDAlgorithms/src/UnaryOperationMD.cpp:        clone->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
MDEvents/src/OneStepMDEW.cpp:      std::string tempWsName = getPropertyValue("OutputWorkspace") + "_nxs";
MDEvents/src/OneStepMDEW.cpp:      childAlg->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
MDEvents/src/OneStepMDEW.cpp:        AnalysisDataService::Instance().retrieve(getPropertyValue("OutputWorkspace")));
MPIAlgorithms/src/BroadcastWorkspace.cpp:      g_log.fatal("InputWorkspace '" + getPropertyValue("InputWorkspace") + "' not found in root process");
WorkflowAlgorithms/src/ComputeSensitivity.cpp:  const std::string outputWS = getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/ComputeSensitivity.cpp:  const std::string patchWSName = getPropertyValue("PatchWorkspace");
WorkflowAlgorithms/src/DgsAbsoluteUnitsReduction.cpp:      std::string outputWsName = this->getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/DgsConvertToEnergyTransfer.cpp:            std::string bkgWsName = this->getPropertyValue("OutputTibWorkspace");
WorkflowAlgorithms/src/DgsDiagnose.cpp:      std::string maskName = this->getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/DgsProcessDetectorVanadium.cpp:            outputFile = this->getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/DgsReduction.cpp:      std::string outputWsName = this->getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/DgsReduction.cpp:      etConv->setProperty("OutputWorkspace", this->getPropertyValue("OutputWorkspace"));
WorkflowAlgorithms/src/DgsReduction.cpp:      std::string tibWsName = this->getPropertyValue("OutputWorkspace") + "_tib";
WorkflowAlgorithms/src/EQSANSDarkCurrentSubtraction.cpp:    std::string darkWSOutputName = getPropertyValue("OutputDarkCurrentWorkspace");
WorkflowAlgorithms/src/EQSANSDarkCurrentSubtraction.cpp:  const std::string outputWSname = getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/EQSANSLoad.cpp:    std::string mon_wsname = getPropertyValue("OutputWorkspace")+"_monitors";
WorkflowAlgorithms/src/EQSANSLoad.cpp:    g_log.error() << "Could not find run number for workspace " << getPropertyValue("OutputWorkspace") << std::endl;
WorkflowAlgorithms/src/EQSANSLoad.cpp:    g_log.error() << "Cound not find config file for workspace " << getPropertyValue("OutputWorkspace") << std::endl;
WorkflowAlgorithms/src/EQSANSLoad.cpp:  dataWS->mutableRun().addProperty("event_ws", getPropertyValue("OutputWorkspace"), true);
WorkflowAlgorithms/src/EQSANSQ2D.cpp:  std::string outputWSName = getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/EQSANSReduce.cpp:  const std::string inputWSName = getPropertyValue("InputWorkspace");
WorkflowAlgorithms/src/HFIRDarkCurrentSubtraction.cpp:  std::string darkWSName = getPropertyValue("OutputDarkCurrentWorkspace");
WorkflowAlgorithms/src/RefReduction.cpp:  const std::string prefix = getPropertyValue("OutputWorkspacePrefix");
WorkflowAlgorithms/src/SANSSensitivityCorrection.cpp:    std::string floodWSOutputName = getPropertyValue("OutputSensitivityWorkspace");
WorkflowAlgorithms/src/SetupEQSANSReduction.cpp:    const std::string outputSensitivityWS = getPropertyValue("OutputSensitivityWorkspace");
WorkflowAlgorithms/src/SetupHFIRReduction.cpp:    const std::string outputSensitivityWS = getPropertyValue("OutputSensitivityWorkspace");

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Description modified (diff)

comment:2 Changed 8 years ago by Russell Taylor

  • Description modified (diff)

comment:3 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:4 Changed 8 years ago by Russell Taylor

Re #6552. Fix a place that was using workspace name, not pointer.

Changeset: 88d7d1b4a55b6f8e11cd95e080332d63fcfb8be9

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from accepted to assigned

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:10 Changed 7 years ago by Russell Taylor

  • Keywords Maintenance added
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

comment:11 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #6552. Use workspace pointers instead of names.

Changeset: 5682b40c9616cfb029c682f496ee1342ff1082b1

comment:12 Changed 7 years ago by Russell Taylor

Re #6552. Remove redundant code.

The Algorithm base class deals with adding the output to the ADS.

Changeset: a9d6c68081d3ba69b84a1ad02122247bcdeddba3

comment:13 Changed 7 years ago by Russell Taylor

Re #6552. Turn ParentWorkspace property into a WorkspaceProperty.

Don't know why it wasn't one in the first place. This allows removing some unnecessary stuff in the algorithm itself.

Changeset: 3ce7fdd4ae724ede41f733856d6d10c949a8af02

comment:14 Changed 7 years ago by Russell Taylor

Re #6552. Remove redundant code.

Changeset: 5cac58c7f45ee031293a1b192be1dd9ad695c5e7

comment:15 Changed 7 years ago by Russell Taylor

Re #6552. Use workspace pointers instead of names.

Changeset: 2c12d457ade007d16193bc0efc5b190e8240c049

comment:16 Changed 7 years ago by Russell Taylor

Re #6552. Remove unused code.

Changeset: f84675e34f20dad89c030c970043500a074580e2

comment:17 Changed 7 years ago by Russell Taylor

Re #6552. Use workspace pointers instead of names.

Changeset: e646f04c393e0b159a8ee61150fe4c9345191038

comment:18 Changed 7 years ago by Russell Taylor

Re #6552. Remove unnecessary code.

Mostly setting the OutputWorkspace property on a child algorithm.

Changeset: 8fb03173d004c8a46afabe17c944a37f6ed869bb

comment:19 Changed 7 years ago by Russell Taylor

Re #6552. Remove unnecessary uses of workspace name.

There's no need to set the output workspace name on a child algorithm.

Changeset: de2aecc731a5c843243cc1fb9dfc378c46bee818

comment:20 Changed 7 years ago by Russell Taylor

Re #6552. Revert one change.

This broke the MaskPeaksWorkspace test, which wanted to mask in-place. This seems to be a shortcoming - that you can't make things happen in-place for child algorithms without using the name.

Changeset: 062d684b14453ce650d0f9255118ca0ffec54d04

comment:21 Changed 7 years ago by Russell Taylor

Re #6552. Use workspace pointers more, names less.

Plus a few other tidy-ups.

Changeset: 814a9b5a9cdaa0b950ad3647f6a6ea5d96c6c97a

comment:22 Changed 7 years ago by Russell Taylor

Put the wrong ticket number in one commit:

Re #6652. Small improvements.

In the end it wasn't correct to change from using the workspace name, but I made a couple of improvements - use the InstrumentValidator and improve the test and make it more efficient.

Changeset: 22c902d1cc920e98225c51f950570f4db9d742bb

comment:23 Changed 7 years ago by Russell Taylor

Here's the updated result of the grep after the above changes. If this ever needs to be revisited, this is the list of places where things are OK (or, in a couple of cases, I wasn't able to change it without breaking things. 

Algorithms/src/CalculateTransmissionBeamSpreader.cpp:    std::string outputWSName = getPropertyValue("OutputWorkspace");
Algorithms/src/CalculateTransmission.cpp:    std::string outputWSName = getPropertyValue("OutputWorkspace");
Algorithms/src/ChangeLogTime.cpp:    msg << "InputWorkspace \'" << this->getPropertyValue("InputWorkspace")
Algorithms/src/ChopData.cpp:  const std::string output = getPropertyValue("OutputWorkspace");
Algorithms/src/CloneWorkspace.cpp:    alg->setPropertyValue("OutputWorkspace", getPropertyValue("OutputWorkspace"));
Algorithms/src/ConjoinWorkspaces.cpp:    AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
Algorithms/src/ConjoinWorkspaces.cpp:  AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
Algorithms/src/ConjoinWorkspaces.cpp:  if (retval) AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
Algorithms/src/CorrectToFile.cpp:    g_log.error() << "Correction file " << getPropertyValue("Filename") + " can't be used to correct workspace " << getPropertyValue("WorkspaceToCorrect") << std::endl;
Algorithms/src/CreateLogTimeCorrection.cpp:    string outwsname = getPropertyValue("OutputWorkspace");
Algorithms/src/CreateWorkspace.cpp:  std::string parentWorkspace = getPropertyValue("ParentWorkspace");
Algorithms/src/CreateWorkspace.cpp:  if (!parentWS || !getPropertyValue("WorkspaceTitle").empty())
Algorithms/src/MaskBinsFromTable.cpp:      maskbins->setProperty("OutputWorkspace", this->getPropertyValue("OutputWorkspace"));
Algorithms/src/Qhelper.cpp:  std::string baseName = alg->getPropertyValue("OutputWorkspace");
Algorithms/src/RemoveLowResTOF.cpp:  std::string lowreswsname = getPropertyValue("LowResTOFWorkspace");
Algorithms/src/RenameWorkspace.cpp:  std::string outputwsName = getPropertyValue("OutputWorkspace");
Algorithms/src/RenameWorkspace.cpp:  if (getPropertyValue("InputWorkspace") == getPropertyValue("OutputWorkspace"))
Algorithms/src/RenameWorkspace.cpp:  std::string outputwsName = getPropertyValue("OutputWorkspace");
Algorithms/src/SassenaFFT.cpp:  const std::string gwsName = this->getPropertyValue("InputWorkspace");
Algorithms/src/ShiftLogTime.cpp:      msg << "InputWorkspace \'" << this->getPropertyValue("InputWorkspace")
API/src/WorkspaceOpOverloads.cpp:            alg->getPropertyValue("OutputWorkspace"));
Crystal/src/AnvredCorrection.cpp:  bool inPlace = (this->getPropertyValue("InputWorkspace") == this->getPropertyValue("OutputWorkspace"));
Crystal/src/OptimizeCrystalPlacement.cpp:      std::string FuncArg = "name=PeakHKLErrors,PeakWorkspaceName=" + getPropertyValue( "PeaksWorkspace" )
Crystal/src/SCDCalibratePanels.cpp:      string PeakWSName = getPropertyValue( "PeakWorkspace");
Crystal/src/SCDCalibratePanels.cpp:      string PeakWSName = getPropertyValue("PeakWorkspace");
DataHandling/src/LiveDataAlgorithm.cpp:    if (this->getPropertyValue("OutputWorkspace").empty())
DataHandling/src/LiveDataAlgorithm.cpp:      if (this->getPropertyValue("AccumulationWorkspace").empty())
DataHandling/src/LiveDataAlgorithm.cpp:      if (this->getPropertyValue("AccumulationWorkspace") == this->getPropertyValue("OutputWorkspace"))
DataHandling/src/LiveDataAlgorithm.cpp:      std::string outName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LiveDataAlgorithm.cpp:      std::string accumName = this->getPropertyValue("AccumulationWorkspace");
DataHandling/src/LiveDataAlgorithm.cpp:          if (!accumName.empty() && alg->getPropertyValue("AccumulationWorkspace") == accumName)
DataHandling/src/LiveDataAlgorithm.cpp:          if (alg->getPropertyValue("OutputWorkspace") == outName)
DataHandling/src/LoadCalFile.cpp:    std::string WorkspaceName = getPropertyValue("WorkspaceName");
DataHandling/src/LoadDAE.cpp:              Workspace_sptr ws = AnalysisDataService::Instance().retrieve(getPropertyValue("OutputWorkspace"));
DataHandling/src/LoadDetectorInfo.cpp:    g_log.warning() << "Note workspace " << getPropertyValue("Workspace") << " has been changed so if you intend to fix detector mismatch problems by running "
DataHandling/src/LoadEventNexus.cpp:  std::string outName = getPropertyValue("OutputWorkspace");
DataHandling/src/LoadISISNexus2.cpp:        const std::string base_name = getPropertyValue("OutputWorkspace") + "_";
DataHandling/src/LoadLiveData.cpp:      std::string inputName = "__anonymous_livedata_input_" + this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadLiveData.cpp:        inputName = this->getPropertyValue("AccumulationWorkspace");
DataHandling/src/LoadLiveData.cpp:        outputName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadLiveData.cpp:        g_log.error() << "Something really wrong happened when adding " << inputName << " to ADS. " << this->getPropertyValue("OutputWorkspace") << std::endl;
DataHandling/src/LoadLiveData.cpp:      if (this->getPropertyValue("AccumulationWorkspace").empty())
DataHandling/src/LoadLiveData.cpp:      std::string outputName = "__anonymous_livedata_convert_" + this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadNexus.cpp:      m_workspace = getPropertyValue("OutputWorkspace");
DataHandling/src/LoadNexusProcessed.cpp:    std::string base_name = getPropertyValue("OutputWorkspace");
DataHandling/src/LoadRawHelper.cpp:        std::string wsName= getPropertyValue("OutputWorkspace");
DataHandling/src/LoadSassena.cpp:  const std::string gwsName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadSassena.cpp:  const std::string gwsName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/LoadSassena.cpp:  const std::string gwsName = this->getPropertyValue("OutputWorkspace");
DataHandling/src/MonitorLiveData.cpp:    std::string AccumulationWorkspace = this->getPropertyValue("AccumulationWorkspace");
DataHandling/src/MonitorLiveData.cpp:    std::string OutputWorkspace = this->getPropertyValue("OutputWorkspace");
DataHandling/src/SaveNexus.cpp:    saveNexusPro->setPropertyValue("WorkspaceIndexList", getPropertyValue("WorkspaceIndexList"));
DataHandling/src/SaveNexus.cpp:    saveNexusPro->setPropertyValue("WorkspaceIndexMax", getPropertyValue("WorkspaceIndexMax"));
DataHandling/src/SaveNexus.cpp:    saveNexusPro->setPropertyValue("WorkspaceIndexMin", getPropertyValue("WorkspaceIndexMin"));
DataHandling/src/SaveRKH.cpp:    << " Workspace: " << getPropertyValue("InputWorkspace") << "\n";
MDAlgorithms/src/ConvertToDiffractionMDWorkspace2.cpp:    Convert->setProperty("OutputWorkspace",this->getPropertyValue("OutputWorkspace"));
MDAlgorithms/src/CreateMDFitWorkspace.cpp://        std::string fname = "C:/Users/hqs74821/Work/InstrumentBug/" + getPropertyValue("OutputWorkspace") + ".csv";
MDEvents/src/OneStepMDEW.cpp:      std::string tempWsName = getPropertyValue("OutputWorkspace") + "_nxs";
MPIAlgorithms/src/BroadcastWorkspace.cpp:      g_log.fatal("InputWorkspace '" + getPropertyValue("InputWorkspace") + "' not found in root process");
WorkflowAlgorithms/src/ComputeSensitivity.cpp:  const std::string outputWS = getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/ComputeSensitivity.cpp:  const std::string patchWSName = getPropertyValue("PatchWorkspace");
WorkflowAlgorithms/src/DgsProcessDetectorVanadium.cpp:            outputFile = this->getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/DgsReduction.cpp:      std::string outputWsName = this->getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/DgsReduction.cpp:      std::string tibWsName = this->getPropertyValue("OutputWorkspace") + "_tib";
WorkflowAlgorithms/src/EQSANSDarkCurrentSubtraction.cpp:    std::string darkWSOutputName = getPropertyValue("OutputDarkCurrentWorkspace");
WorkflowAlgorithms/src/EQSANSDarkCurrentSubtraction.cpp:  const std::string outputWSname = getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/EQSANSLoad.cpp:    std::string mon_wsname = getPropertyValue("OutputWorkspace")+"_monitors";
WorkflowAlgorithms/src/EQSANSLoad.cpp:    g_log.error() << "Could not find run number for workspace " << getPropertyValue("OutputWorkspace") << std::endl;
WorkflowAlgorithms/src/EQSANSLoad.cpp:    g_log.error() << "Cound not find config file for workspace " << getPropertyValue("OutputWorkspace") << std::endl;
WorkflowAlgorithms/src/EQSANSLoad.cpp:  dataWS->mutableRun().addProperty("event_ws", getPropertyValue("OutputWorkspace"), true);
WorkflowAlgorithms/src/EQSANSQ2D.cpp:  std::string outputWSName = getPropertyValue("OutputWorkspace");
WorkflowAlgorithms/src/HFIRDarkCurrentSubtraction.cpp:  std::string darkWSName = getPropertyValue("OutputDarkCurrentWorkspace");
WorkflowAlgorithms/src/RefReduction.cpp:  const std::string prefix = getPropertyValue("OutputWorkspacePrefix");
WorkflowAlgorithms/src/SANSSensitivityCorrection.cpp:    std::string floodWSOutputName = getPropertyValue("OutputSensitivityWorkspace");
WorkflowAlgorithms/src/SetupEQSANSReduction.cpp:    const std::string outputSensitivityWS = getPropertyValue("OutputSensitivityWorkspace");
WorkflowAlgorithms/src/SetupHFIRReduction.cpp:    const std::string outputSensitivityWS = getPropertyValue("OutputSensitivityWorkspace");

comment:24 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: Branch is feature/6552_use_workspace_ptr_if_poss

I think this mostly needs to be a case of relying on the tests, though do of course look over the changes. You could also pick a couple of changed algorithms at random and manually make sure they are still working.

comment:25 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:26 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7398

Note: See TracTickets for help on using tickets.