Ticket #6872 (closed: duplicate)

Opened 7 years ago

Last modified 5 years ago

Be more flexible when instrument_source entry not defined in Nexus

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: critical Milestone: Release 3.2
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Anders Markvardsen) (diff)

If instrument_source nexus element not included in the nexus instrument entry Mantid does not read in any stored instrument.

For example the attached processed nexus, SANS2D00011109-add.nxs, file does not have a instrument_source for some reason which means that the stored instrument description is not loaded

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Summary changed from Be more gratious when no instrument_source defined in Nexus to Be more grateful when instrument_source entry not defined in Nexus

Even in zipped form SANS2D00011109-add.nxs is to big to be attached. will attach another file later

comment:2 Changed 7 years ago by Anders Markvardsen

  • Summary changed from Be more grateful when instrument_source entry not defined in Nexus to Be more flexible when instrument_source entry not defined in Nexus

comment:3 Changed 7 years ago by Anders Markvardsen

  • Milestone changed from Release 2.5 to Release 2.6

comment:4 Changed 7 years ago by Nick Draper

  • Priority changed from blocker to critical
  • Keywords Maintenance added

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:9 Changed 7 years ago by Anders Markvardsen

  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.1

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:11 Changed 7 years ago by Anders Markvardsen

  • Milestone changed from Backlog to Release 3.2

comment:12 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to verify
  • Resolution set to duplicate

It looks like Russell has fixed this as part of #8108.

Now when I load SANS2D00011109-add.nxs I get the response:

Attribute 'mark-as' is a depricated attribute in Instrument Definition File. Please see the deprecated section of www.mantidproject.org/IDF for how to remove this warning message Attribute 'mark-as' is a depricated attribute in Instrument Definition File. Please see the deprecated section of www.mantidproject.org/IDF for how to remove this warning message Attribute 'mark-as' is a depricated attribute in Instrument Definition File. Please see the deprecated section of www.mantidproject.org/IDF for how to remove this warning message Attribute 'mark-as' is a depricated attribute in Instrument Definition File. Please see the deprecated section of www.mantidproject.org/IDF for how to remove this warning message

which shows me that the embedded IDF have been loaded, because this is an old nexus file that contains an old SANS2D IDF version

comment:13 Changed 7 years ago by Anders Markvardsen

To tester:

Either simply accept the comment 12 or ask me to email the file SANS2D00011109-add.nxs if you would like to test that bug reported in this ticket now works

comment:14 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:15 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Yes, I made modifications in this area.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7718

Note: See TracTickets for help on using tickets.