Ticket #6881 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add option for "save" in mask tab of instrument view

Reported by: Peter Peterson Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Wenduo Zhou) (diff)

SNAP needs a few more features in the mask tab:

  1. The option to generate the mask workspace/file with grouping.
  2. The option to generate a masking table workspace (using currently visable x-range). It will be used with MaskBinsFromTable.

Change History

comment:1 Changed 7 years ago by Alex Buts

refs #6881 A bit less shared pointers.

Changeset: 8edea31bf234bbc92e73b653372ee952ebb100fb

comment:2 Changed 7 years ago by Alex Buts

refs #6881 A bit less shared pointers.

Changeset: 8edea31bf234bbc92e73b653372ee952ebb100fb

comment:3 Changed 7 years ago by Wenduo Zhou

  • Description modified (diff)

comment:4 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:5 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:6 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #6881.

Changeset: 3d6bf08ab37c31d7978878e3c7e0895125a9cabd

comment:7 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:8 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Feature "The option to generate a masking table workspace (using currently visable x-range). It will be used with MaskBinsFromTable. " will be implemented in a ticket #6904.

comment:9 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:10 Changed 7 years ago by Roman Tolchenov

Testing steps from Wenduo:

  1. SumNeightbors(). Sum it to 2 x 2
  2. Open the instrument view.
  3. select an area to mask
  4. Click button "Apply and Save"; select "As Mask To File"

If "group detectors" is not checked, then you will see an error message "Impossible Situation! Workspace 7314 corresponds to #(Det) = 4 Logic Error in execution of algorithm SaveMask Impossible number of detectors"

if it is checked, save should be successful

comment:11 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Used file CNCS_7860_event.nxs. Works as described above.

comment:12 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:13 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:14 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:15 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:16 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #6881.

Changeset: 3d6bf08ab37c31d7978878e3c7e0895125a9cabd

comment:17 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:18 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:19 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:20 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #6881.

Changeset: 3d6bf08ab37c31d7978878e3c7e0895125a9cabd

comment:21 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:22 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #6881.

Changeset: 3d6bf08ab37c31d7978878e3c7e0895125a9cabd

comment:23 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:24 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:25 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:26 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #6881.

Changeset: 3d6bf08ab37c31d7978878e3c7e0895125a9cabd

comment:27 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #6881.

Changeset: 3d6bf08ab37c31d7978878e3c7e0895125a9cabd

comment:28 Changed 7 years ago by Alex Buts

refs #6881 A bit less shared pointers.

Changeset: 8edea31bf234bbc92e73b653372ee952ebb100fb

comment:29 Changed 7 years ago by Wenduo Zhou

Add checkbox to mask gui. Refs #6881.

Changeset: 2e9ca1d49710481a65e1c367b8f953c9a2075b34

comment:30 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/6881_save_mask'. Re #6881

Changeset: 0c774f59bac1a07454f4cdfd15de42a82ce252d5

comment:31 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6804_warnings' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:32 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6804_warnings' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:33 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7727

Note: See TracTickets for help on using tickets.