Ticket #7376 (closed: fixed)
[IDA] - Improve Fury, FuryFit, msdFit and ApplyCorr
| Reported by: | Dereck Kachere | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Roman Tolchenov) (diff)
- Change Fury to no longer pass Time in WS xlabel.
- For FuryFit, MSD Fit and Apply Corrections, change the format of result WS to that used by the Fit algorithm output. Also make so that the WS has name *_Result and is a GroupWorkspace with a WS for each spectrum which has histograms for Data, Calc & Diff.
- Update Apply Corrections routine to be functional with the new API.
Attachments
Change History
comment:2 Changed 7 years ago by Dereck Kachere
- Status changed from new to accepted
- Owner set to Dereck Kachere
comment:3 Changed 7 years ago by Dereck Kachere
- Description modified (diff)
FuryFit, MSD Fit and Apply Corrections now have an extra grouped workspace. They still function in the same way.
Tester:
Run IDA as shown on the Examples page on the wiki, except for in Elwin where you will have to operate on multiple runs - all of the files attached to this ticket - and use the results from that to verify that MSD Fit still functions in the same way; one has to use more than one run since there is a grouped workspace as an output.
comment:4 Changed 7 years ago by Dereck Kachere
- Owner changed from Dereck Kachere to Martyn Gigg
- Status changed from accepted to assigned
comment:6 Changed 7 years ago by Martyn Gigg
Add FuryFitMultiple python algorithm for indirect data analysis
Refs #7376
Changeset: 0e425eb8f844f211a75f8a5366fdddfb741cc491
comment:7 Changed 7 years ago by Martyn Gigg
Update ISIS Indirect Fury results. Refs #7376
Changeset: c8c7d1f49573a2141612e60d610d77d09b82ea8c
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
Branch: feature/7376_improve_indirect_data_analysis in BOTH code & systemtests repositories.
Tester: Run IDA as shown on the Examples page on the wiki, except for in Elwin where you will have to operate on multiple runs - all of the files attached to this ticket - and use the results from that to verify that MSD Fit still functions in the same way; one has to use more than one run since there is a grouped workspace as an output.
Spencer has checked the changes (on an installer) and is happy with them.
comment:9 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:10 Changed 7 years ago by Martyn Gigg
Missed a return statement in furyFitSeq. Refs #7376
Changeset: 47378c7395e68448f92dcd112d4a9a5d82bf1345
comment:11 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:13 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
There's no clash with stuff that is now on master so it should be okay.
comment:14 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester changed from Roman Tolchenov to Samuel Jackson
comment:15 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to reopened
- Resolution fixed deleted
First time I load a file into Elwin it works fine. When loading a second file it appears not to load the file into a workspace. Clicking "plot input" then causes Mantid to crash.
comment:16 Changed 7 years ago by Martyn Gigg
Add error-checking to IDA tabs when loading files. Refs #7376
Changeset: a2615b84e1af5fb42475726271d23f2d03362399
comment:17 Changed 7 years ago by Martyn Gigg
Missed a return statement in IDATab. Refs #7376
Changeset: 08fed4a94da5031d8388559cf0b461cfa095ecb5
comment:19 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:20 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Description modified (diff)
- Tester changed from Samuel Jackson to Roman Tolchenov
comment:21 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7376_improve_indirect_data_analysis'
comment:22 Changed 7 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/feature/7376_improve_indirect_data_analysis'
comment:23 Changed 7 years ago by Nick Draper
- Component changed from Framework to Indirect Inelastic
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8222
refs #7376 New output workspace within tabs in the IDA interface.
Changeset: 0f15081d9af4f3d8e9594d85392295c50f6e1623