Ticket #7480 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix GCC compiler warnings

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Clear those that have got into the master branch for our supported platforms.

Change History

comment:1 Changed 7 years ago by Russell Taylor

Re #7480. Remove unused variable.

Changeset: 96f8431bcd28dd91090a8635f736bd0275e32eef

comment:2 Changed 7 years ago by Russell Taylor

Re #7480. Don't initialise variable unnecessarily.

Changeset: 4305efdb7648a98bc4252d305afe82d8341ea7ba

comment:3 Changed 7 years ago by Russell Taylor

Re #7480. Remove unused variable.

Changeset: 3ae585b7f280731246b4be0e0cf5aa47c0d38bdf

comment:4 Changed 7 years ago by Russell Taylor

Re #7480. Remove unused variable (gave cppcheck warning).

Changeset: 7b45de88208eecf78059a104cee9a9d7955f0053

comment:5 Changed 7 years ago by Russell Taylor

Re #7480. Try to clear GCC compiler warning.

Changeset: 65b8f667438e065541c19ea712d4b219ed300ac1

comment:6 Changed 7 years ago by Russell Taylor

Re #7480. Clear cppcheck warnings while I have the file open.

Changeset: a992a1dbfbb2fd83c78613380b809b403e0150dd

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

comment:8 Changed 7 years ago by Russell Taylor

Re #7480. Remove variable that's not used in anger.

Changeset: ca56ae09e5fbc7df75dee63d2b99df9468c46213

comment:9 Changed 7 years ago by Russell Taylor

Last edited 7 years ago by Russell Taylor (previous) (diff)

comment:10 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

There should be no more warnings in the develop clean RHEL6 builds. There is one warning still in the Ubuntu 12.04 build in RemoteJobManager.cpp. I think an older version of Poco must be on that system, where Poco::Net::HTTPMessage::setContentLength takes in int - in the newer versions that we use everywhere else it takes a wider type.

comment:11 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:12 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

0 compiler warnings on RHEL6

comment:13 Changed 7 years ago by Russell Taylor

I just did the merge to master myself as Andrei forgot to - again :)

comment:14 Changed 7 years ago by Nick Draper

  • Component changed from Other to Framework

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8325

Note: See TracTickets for help on using tickets.