New file/workspace selector widget

[Samuel Jackson]

Both the IDA and C2E interface make use of a combination of WorkspaceSelectors and MWRunsFiles to get the names of either a workspace or a file to work with. This pattern could benefit from become a separate Mantid widget to prevent code repetition and could easily be used elsewhere in Mantid. This is especially true as several upcoming tickets will use the exact same pattern several times over.

[Samuel Jackson]

Added new widget and connected it to Fury interface.

Refs #7681

Changeset: 45546ec689c9959db576b7e70272823b2269ee5a

[Samuel Jackson]

Replacing check for valid res file.

Refs #7681

Changeset: 7371af37e44da9e74091dbc425326e1f69d4ce1c

[Samuel Jackson]

Added check to stop auto plotting when workspace selector not visible

Refs #7681

Changeset: 17dbd62a45033c5bb088753449aa1dd9c4a7d828

[Samuel Jackson]

To Test

A new Mantid Widget has been created. To test that it functions correctly, I've replaced the existing GUI components in the Fury IDA tab. The widget is a combination of a workspace selector and a file browser and should provide the same functionality as the existing interface but within a single widget

To test this I recommend checking how the existing fury interface works and then checking that the new interface behaves the same.

[Samuel Jackson]

Adding settings saving for selected directory

Refs #7681

Changeset: 99c8c1affa90533763a3e416bd9798b7a481eb3c

[Samuel Jackson]

Made the load button optional.

This should make the widget more applicable to a wider number of interfaces.

Refs #7681

Changeset: a88bba0bac87dfea60fbda1dbb203baf403e904e

[Samuel Jackson]

Setting Fury back to the way it was.

Refs #7681

Changeset: 0e3db76d4c7e7542ad07e51119cbbf083e8d65a8

[Russell Taylor]

There's a warning on the console now when starting up the interface:

Object::connect: No such slot MantidQt::MantidWidgets::DataSelector::loadClicked()
Object::connect:  (sender name:   'pbLoadFile')
Object::connect:  (receiver name: 'DataSelector')

Also, if 'Workspace' is selected it includes different workspaces. Before it seemed to be looking for workspace names ending in "res" or "sqw". Now it's "red" or "sqw". Please confirm if this is a correct change.

[Samuel Jackson]

Changed loadClicked from slot to signal.

Refs #7681

Changeset: 28d3dda9a8a62f27d868e22f0a6ea5358c059d90

[Russell Taylor]

I found a regression: if the data files are not on your directory search path, the analysis fails with the following error:

ValueError: Invalid value for property Filename (string) "irs55127_graphite002_red": File "irs55127_graphite002_red" not found
  at line 9 in '<Interface>'
  caused by line 429 in '/home/tr9/TestingMantid/Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py'

Calling completeBaseName() on the filename in DataSelector::getCurrentDataName() would appear - in this context at least - to be an error.

[Samuel Jackson]

Changed Fury to use workspaces rather than load files.

Using the new interface component should ensure that the files have already been loaded and therefore they should already be available to the algorithm when Fury is run.

Refs #7681

Changeset: a9b35b936fd8642fccf1ccc138251c590572354f

[Samuel Jackson]

Tester

I've made some changes to Fury in the last commit, so it would be a good idea to check the output of fury against the the output from another copy of Mantid to check it's still the same as well as doing the previously stated testing.

[Russell Taylor]

Merge remote branch 'origin/feature/7681_new_mantid_widget'

[Samuel Jackson]

Changed Fury to use workspaces rather than load files.

Using the new interface component should ensure that the files have already been loaded and therefore they should already be available to the algorithm when Fury is run.

Refs #7681

Changeset: 64561c2562111880cf409a3155d57714f689cbdb

[Russell Taylor]

Oops, because the system tests have been broken for days, I only just noticed that the last commit looks to have broken the IRISFuryAndFuryFit & OSIRISFuryAndFuryFit system tests:

  File "/home/builder/jenkins/workspace/ornl_test_rhel6_develop/SystemTests/AnalysisTests/ISISIndirectInelastic.py", line 586, in _run
    Plot=False)
  File "/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py", line 427, in fury
    nsam,npt = CheckHistZero(samTemp)
  File "/opt/Mantid/scripts/Inelastic/IndirectCommon.py", line 187, in CheckHistZero
    nhist = mtd[inWS].getNumberHistograms()       # no. of hist/groups in WS
KeyError: "'osi97935_graphite002_red.nxs' does not exist."

I've removed the merge commit from master and resurrected the topic branch on github so this can be fixed.

[Samuel Jackson]

Corrected system test to load the files it needs.

Refs #7861

Changeset: 13b4a1240d1ac2c4aec3f72a2d23695febb18834

[Samuel Jackson]

I've updated the system tests for Fury and FuryFit.

Note that I typed the ticket number wrong. The system tests branch that requires merging is #7861_new_mantid_widget despite this being ticket #7681.

[Samuel Jackson]

Updated unit system tests on the correct branch number this time.

Refs #7681

Changeset: 6df5647bbb368e529eab6bf525a9d9a42ec0996f

[Samuel Jackson]

Changed Fury to use workspaces rather than load files.

Using the new interface component should ensure that the files have already been loaded and therefore they should already be available to the algorithm when Fury is run.

Refs #7681

Changeset: a9b35b936fd8642fccf1ccc138251c590572354f

[Samuel Jackson]

Tidy up system test to remove file extension.

Refs #7681

Changeset: aae2c947f66c3421a08295789eb3fadf313265ca

[Samuel Jackson]

Added fall back load statement just in case the user manages remove the workspace.

Refs #7681

Changeset: ebdf0385017e222f4c141a9efd248334b852759f

[Russell Taylor]

The branch in the system tests repository (​https://github.com/mantidproject/systemtests/tree/feature/7681_new_mantid_widget) needs updating on github because it doesn't contain the last commit (which is only in develop on the server).

[Russell Taylor]

Merge remote branch 'origin/feature/7681_new_mantid_widget'

[Samuel Jackson]

Merge branch 'feature/7681_new_mantid_widget' of github.com:mantidproject/mantid into feature/7681_new_mantid_widget

[Russell Taylor]

Merge remote branch 'origin/feature/7681_new_mantid_widget'

[Stuart Campbell]

This ticket has been transferred to github issue ​8526