Ticket #7792 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Change date attribute in parameter files

Reported by: Mike Thomas Owned by: Mike Thomas
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Mike Thomas) (diff)

A schema has been written to validate all parameter files. The attribute for date must now be 'valid-from' or 'valid-to'. With both attributes optional. This replaces the convention of using 'date'.

Change History

comment:1 Changed 7 years ago by Mike Thomas

  • Description modified (diff)
  • Summary changed from Change date attribute in REF_L_Parameters.xml to Change date attribute in parameter files

comment:2 Changed 7 years ago by Nick Draper

  • Owner set to Mike Thomas

comment:3 Changed 7 years ago by Mike Thomas

  • Status changed from new to inprogress

Commit parameter files date attribute changed Refs #7792

Changeset: ccf3e687761269881d14655a8643019f7cc91bc2

comment:4 Changed 7 years ago by Mike Thomas

  • Owner changed from Mike Thomas to Anders Markvardsen

comment:5 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test: check date attributes changed

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The old 'date' is found in all these entries: 

Code/Mantid/instrument/IDFs_for_UNIT_TESTING/HRPDTEST_Parameters_Test6.xml
Code/Mantid/instrument/IDFs_for_UNIT_TESTING/HRPD_Parameters_Test4.xml
Code/Mantid/instrument/IDFs_for_UNIT_TESTING/IDF_for_UNIT_TESTING2_paramFile.xml
Code/Mantid/instrument/IDFs_for_UNIT_TESTING/HRPDTEST_Parameters.xml
Code/Mantid/Framework/DataHandling/src/LoadParameterFile.cpp
Code/Mantid/Framework/Crystal/src/SCDCalibratePanels.cpp

comment:8 Changed 7 years ago by Mike Thomas

  • Status changed from reopened to inprogress

remove old date attribute Refs #7792

Changeset: 8cfe99ce3387109bc2aea88619ecc0d169600a16

comment:9 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Anders Markvardsen

To test: re-check date attributes changed

comment:11 Changed 7 years ago by Nick Draper

  • Owner changed from Anders Markvardsen to Mike Thomas

After the summer contact Anders Markvardsen about these tickets

comment:12 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester changed from Gesner Passos to Karl Palmen

comment:13 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

No occurences of 'date=' found in any *.xml file within .../mantid/instrument and its subfolders.

I also note that Mantid currently ignores this date parameter now changed to valid-from, hence no change in the code is needed.

Last edited 7 years ago by Karl Palmen (previous) (diff)

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8637

Note: See TracTickets for help on using tickets.