Ticket #7808 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

reduce cppcheck errors

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description


Change History

comment:1 Changed 7 years ago by Nick Draper

Before: 

Total 422
Severity 'error' 1
Severity 'warning' 0 
Severity 'style' 392
Severity 'performance' 10
Severity 'information' 18
No category 1

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to inprogress

First batch refs #7808

Changeset: 9587df89d13b9588434d2ac4774f027b750379ea

comment:3 Changed 7 years ago by Nick Draper

second batch refs #7808

Changeset: b62c13f02abfc9d354a568e4067c01edac104437

comment:4 Changed 7 years ago by Nick Draper

third batch refs #7808

Changeset: 08fd0c57c0298e41a32884f414607aa4d4a7c75f

comment:5 Changed 7 years ago by Nick Draper

fixed typo that slipped through refs #7808

Changeset: e605e286a0d487739a43ee0e058b2b0823a1e49e

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester:

Please do not leave this too long before testing, with this number of changes it is just begging to cause merge conflicts.

This not directly a testable ticket, you should however:

  1. Check that all unit tests passed on the nightly develop build
  2. Check that the system tests all passed
  3. Use Git test review to see that the changes seem reasonable.

comment:7 Changed 7 years ago by Nick Draper

Ideally also manually start the cppcheck job after merging and see some benefit.

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:9 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Using cppcheck v1.59 on RHEL6:

  • before: 422 issues
  • after: 326 issues

The only comment is the branch should have started with "bugfix" rather than "feature."

comment:10 Changed 7 years ago by Vickie Lynch

Last edited 7 years ago by Vickie Lynch (previous) (diff)

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8653

Note: See TracTickets for help on using tickets.