EQSANS: issue with running reduction twice

[Mathieu Doucet]

A recent feature added to the EQSANS reduction is the ability to use an event workspace as the input of the reduction instead of a file. This causes a problem when a run number is used as the data input. The reduction then loads the file and calls the workspace by the run number. If you hit reduce a second time it will try to reload that workspace, which will make the reduction fail.

The logic that looks for a workspace should be updated to check that the given workspace not only exists but is an event workspace that was not already reduced.

[Mathieu Doucet]

Re #7828 Add event workspace check

Changeset: 0ea89b1efefee0db73033566ed7f2d8f71c38d1f

[Mathieu Doucet]

To test:

• In the MantidPlot options, set SNS/EQSANS as your default instrument.
• Make sure the systemtests Data directory is in the list of your Mantid data directories.
• From MantidPlot's Interfaces menu, start the ORNL SANS UI.
• If the EQSANS reduction UI doesn't start, go under Tools of the UI that just popped up and pick Change instrument: then pick EQSANS.
• Under Tools of the EQSANS UI, make sure to turn on debug mode.
• Fill in reduction options:
  • Enter only a run number (use 3293) in the scattering data file field of the Data tab.
  • Under the Transmission section of the same tab, click the Fix transmission box and enter 1 for the transmission value.
• Hit reduce, the reduction should complete and a workspace with the run number as a name should appear.
• Hit reduce again. The reduction should run again to completion, without error. The results should be the same.

[Jay Rainey]

I wasn't exactly sure which files to use in order to test. If possible could one of the SNS guys write a short guide on how to use the EQSANS reduction interface?

[Mathieu Doucet]

I've updated the testing instructions above (comment:2).

[Russell Taylor]

Merge remote branch 'origin/feature/7828_fix_repeated_eqsans_reduction'

[Stuart Campbell]

This ticket has been transferred to github issue ​8673