Stop plots being redrawn when not needed and jump around the window

[Arturs Bekasovs]

Currently in Muon Analysis we are redrawing plots on every change in truly random places. That means creating new workspace and doing all the calculations even if just the type of line is changed.

We can do it so that if the style of the plot changes, and the plot is already created, just update it without closing. If is not created - plot using new style parameters.

By style here I mean parameters "Connect Points", "Y-axis", "Error Bars". All the others apparently require workspace to be recalculated.

The same applies to changing workspace in Data Analysis - we don't need closing and redrawing the graph if it's already visible. (This will solve the problem occurred in #5116)

[Arturs Bekasovs]

I was not able to implement remembering of previous plot window, as there is no functionality available to create a plot at a specific place. It means that I can only create a plot somewhere, and then move it to the position of the previous plot, which looks ugly. So leave this part for now, do other improvements and close the ticket.

We can discuss the importance of skipped part on the next meeting with Muon scientists.

[Arturs Bekasovs]

Updated description to reflect what I've done.

[Arturs Bekasovs]

Don't replot when not necessary on DA tab.

Refs #7887

Changeset: 6c4015941f4110ad0b5b6f505f7ff3a7163cdc6a

[Arturs Bekasovs]

Don't replot when only style changes.

Refs #7887

Changeset: 5cfa26a8cbb6c8a7fe11359b2640fd4bb6756dc9

[Arturs Bekasovs]

Fixed some commenting.

Refs #7887

Changeset: 2bc41a897686827eb24fcc442ffb150606ecdf94

[Arturs Bekasovs]

Tester:

Please check the following use cases:

1. User plots something, goes to settings tab and changes style parameters, i.e. "Connect Points", "Y-axis", "Error Bars". When auto-update is enabled, the style of the plot should update instantly without it being moved.

2. User plots something and goes to Data Analysis tab to fit it. Peak Picker tool (blue striped lines) should be attached to the current plot. While this happens, the plot should not be moved or redrawn.

3. On Data Analysis tab, user changes the workspace he wants to fit inside Fit Property Browser. If the plot of selected workspace already exists, it gets activated and PP tool gets assigned to it, without plot being re-drawn or moved. If it doesn't exist - it gets created first.

[Peter Parker]

Merge remote-tracking branch 'origin/feature/7887_muon_plot_jumping'

Full changeset: ​cd02c8307ed40b237309f9b42496af7140869616

[Peter Parker]

The changes make the interface much more user-friendly. The use cases work as described. The code looks good.

[Stuart Campbell]

This ticket has been transferred to github issue ​8732